Only Include Top Most SDK Frame in Generated Stacktraces

[sindresorhus]

Environment

SaaS (https://sentry.io/)

Version

No response

Steps to Reproduce

• View a crash report for a report submitted by SentrySDK.captureError() (Sentry Cocoa 7.5.2)
• Make sure it's showing "App Only" view.

Expected Result

I expected it to only show stack traces for my app.

Actual Result

The first stack trace is:

-[SentryStacktraceBuilder buildStacktraceForCurrentThread]

While I understand it sometimes can be useful to see where it crashed in a system framework. Seeing internal Sentry stack traces is not useful.

[getsentry-release]

Routing to @getsentry/team-mobile for triage. ⏲️

[bruno-garcia]

Thanks for raising @sindresorhus . Sentry's frames shouldn't be included in In App.
We'll take a look

[bruno-garcia]

To confirm: Do you see the Sentry frame like this:

As in: Crashed in?

Because it's not showing as In App on our samples:

[bruno-garcia]

If you're using the SaaS, could you please share the link of an event in Sentry?

[sindresorhus]

Example:

Link: https://sentry.io/organizations/sindresorhus/issues/2783616404/events/478adbd81a0a4f05bd77c50222fd3906/

[philipphofmann]

@bruno-garcia and @sindresorhus, Sentry doesn't mark the frames of the Cocoa SDK as in-app, see.

This grouping rule makes sure to mark frames starting with Sentry as non -n-app.
https://github.com/getsentry/sentry/blob/d81985575e1b0a9eebdb65f240db02c6f52ec2ff/src/sentry/grouping/enhancer/enhancement-configs/mobile%402021-04-02.txt#L68

@sindresorhus, above you mentioned

While I understand it sometimes can be useful to see where it crashed in a system framework. Seeing internal Sentry stack traces is not useful.

Do you think we should remove the whole stacktrace of the SentrySDK from captureError to buildStacktraceForCurrentThread?

[sindresorhus]

Do you think we should remove the whole stacktrace of the SentrySDK from captureError to buildStacktraceForCurrentThread?

Yes. Or at least only show the single (first) [SentrySDK captureError] stack frame. Everything after is just noise.

[philipphofmann]

It kind of makes sense, @sindresorhus. I add this to our backlog. It should be an easy fix (last famous words 😁) as these frames are not marked as in-app they shouldn't have an impact on grouping, but we should double-check that.

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[sindresorhus]

Please keep this open.