fix: MachException Improvements #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on #2642. Fixes applied from KSCrash: * kstenerud/KSCrash#349 * kstenerud/KSCrash#350 Add exception codes for ARM from mach/arm/exception.h. Add missing kernel return codes from kern_return.h
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b2f82fa | 1236.94 ms | 1262.86 ms | 25.92 ms |
| 4977fbc | 1217.26 ms | 1239.82 ms | 22.56 ms |
| 0dedab7 | 1221.26 ms | 1235.34 ms | 14.08 ms |
| c6504da | 1232.06 ms | 1243.28 ms | 11.22 ms |
| 156e771 | 1228.06 ms | 1242.64 ms | 14.58 ms |
| 621ba9b | 1190.66 ms | 1230.84 ms | 40.18 ms |
| 7c5d161 | 1224.38 ms | 1249.66 ms | 25.28 ms |
| b2f82fa | 1237.78 ms | 1256.02 ms | 18.24 ms |
| dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
| 15b8c61 | 1223.16 ms | 1244.83 ms | 21.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
| 4977fbc | 20.76 KiB | 419.85 KiB | 399.10 KiB |
| 0dedab7 | 20.76 KiB | 420.00 KiB | 399.24 KiB |
| c6504da | 20.76 KiB | 414.44 KiB | 393.69 KiB |
| 156e771 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 621ba9b | 20.76 KiB | 414.45 KiB | 393.69 KiB |
| 7c5d161 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
| b2f82fa | 20.76 KiB | 419.62 KiB | 398.86 KiB |
| dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
| 15b8c61 | 20.76 KiB | 419.67 KiB | 398.91 KiB |
Previous results on branch: fix/kscrash-mach-exception-improvements
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc55afc | 1224.33 ms | 1238.50 ms | 14.17 ms |
| e270fb5 | 1198.21 ms | 1225.64 ms | 27.43 ms |
| 731cacf | 1243.12 ms | 1255.56 ms | 12.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc55afc | 20.76 KiB | 420.36 KiB | 399.61 KiB |
| e270fb5 | 20.76 KiB | 420.34 KiB | 399.58 KiB |
| 731cacf | 20.76 KiB | 420.34 KiB | 399.58 KiB |
We forgot to add onUIntegerElement to SentryCrashReportFixer. So the SDK crashed while reading the crash report on the app start. This is fixed now by adding onUIntegerElement. Furthermore, I validated that all SentryCrashJSONDecodeCallbacks now have a mapping to onUIntegerElement.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
+ Coverage 80.56% 80.57% +0.01%
==========================================
Files 246 247 +1
Lines 22864 22945 +81
Branches 10113 10138 +25
==========================================
+ Hits 18420 18488 +68
- Misses 3984 3993 +9
- Partials 460 464 +4
Continue to review full report at Codecov.
|
6 tasks
brustolin
approved these changes
Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Follow up on #2642. Fixes applied from KSCrash:
💡 Motivation and Context
Could fix GH-1589.
💚 How did you test it?
Code was reviewed by KSCrash maintainers and the fork of Bugsnag applied the same changes bugsnag/bugsnag-cocoa#806
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps