Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't invoke beforeSend for transactions #1730

Open
philipphofmann opened this issue Mar 29, 2022 · 3 comments
Open

Don't invoke beforeSend for transactions #1730

philipphofmann opened this issue Mar 29, 2022 · 3 comments
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Cocoa
Milestone

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Mar 29, 2022

Description

The SDK must not invoke beforeSend for transactions. If users want to drop transactions, they should instead use event processors, see https://develop.sentry.dev/sdk/performance/#interaction-with-beforesend-and-event-processors or beforeSendTransaction see #3339.

As some users might rely on calling beforeSend to drop transactions and event processors are not public, this change is a breaking change. Please remember that some users could also use beforeSend to send transactions to another endpoint, so we have to provide an alternative.

@ndmanvar
Copy link
Contributor

@philipphofmann please let me know if we fix this

@philipphofmann
Copy link
Member Author

philipphofmann commented Apr 12, 2022

@ndmanvar, we can only fix this with a major version as pointed out above

As some users might rely on calling beforeSend to drop transactions and event processors are not public, this change is a breaking change. Please remember that some users could also use beforeSend to send transactions to another endpoint, so we have to provide an alternative.

So when we are going to fix this, we make sure to not break anybody.

@github-actions
Copy link

github-actions bot commented May 4, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Cocoa
Projects
Status: Backlog
Development

No branches or pull requests

4 participants