-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't invoke beforeSend for transactions #1730
Comments
@philipphofmann please let me know if we fix this |
@ndmanvar, we can only fix this with a major version as pointed out above
So when we are going to fix this, we make sure to not break anybody. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Description
The SDK must not invoke
beforeSend
for transactions. If users want to drop transactions, they should instead use event processors, see https://develop.sentry.dev/sdk/performance/#interaction-with-beforesend-and-event-processors or beforeSendTransaction see #3339.As some users might rely on calling
beforeSend
to drop transactions and event processors are not public, this change is a breaking change. Please remember that some users could also usebeforeSend
to send transactions to another endpoint, so we have to provide an alternative.The text was updated successfully, but these errors were encountered: