-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically trace CAAnimationDelegate
start/stop methods
#1890
Comments
The use case for this is to determine if your animations cause glitches. If we added spans for animations, this wouldn't help much because you don't know which span had glitches. It would make sense to add the amount of total, slow and frozen frames to spans, see #1912 Most animations won't happen for auto-generated UIViewController transactions, but instead for UI event transactions. Consider repeating animations without an end. Related to #1843 and getsentry/team-mobile#4 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Problem Statement
It could be helpful for developers to be made aware of degraded performance of animations they build using Core Animation. We could use our automatic instrumentation to start and stop a span on
animationDidStart:
/animationDidStop:
towards this end.Solution Brainstorm
We could examine the classes delivered in an application binary and check to see if they conform to the
CAAminationDelegate
protocol and then swizzleanimationDidStart:
/animationDidStop:
to create the span.The text was updated successfully, but these errors were encountered: