build: Migrate Yarn from Berry v3.6.4 to v4.17.0 (#6417)

* build: Migrate Yarn from Berry v3.6.4 to v4.17.0

Yarn Berry v3 is end-of-life (last release 3.8.6, 2024). Bumping to the
intermediate 3.8.6 is not viable: its bundled compat/typescript patch
fails to apply to the modern TypeScript versions used across the
workspaces (Cannot apply hunk). Yarn 4 ships an up-to-date patch that
applies cleanly, so v4 is the working path.

- Bump packageManager to yarn@4.17.0 (corepack-managed)
- Pin downlevel-dts's TypeScript to a stable 5.9.3 via resolutions;
  its typescript@npm:next dependency froze to a nightly build that no
  yarn compat patch (v3 or v4) can patch
- Add enableScripts: true to .yarnrc.yml to preserve prior behavior;
  yarn 4 flipped this default to false, which would otherwise disable
  dependency build scripts (geckodriver, nx, pmd-bin, sharp)

Dev-tooling only: the published @sentry/react-native package carries no
yarn config, so there is no consumer impact.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(e2e): Disable yarn 4 release-age gate for generated test app

The e2e CLI creates a throwaway RN app with an empty yarn.lock and runs a
fresh install. Under yarn 4 (this branch's package manager), the install
auto-enables hardened mode on public-PR CI and quarantines any package
newer than npmMinimalAgeGate (default 1 day). A just-published first-party
@sentry/* version — e.g. right after a JS SDK bump — is therefore rejected
and fails the install.

Write enableHardenedMode: false and npmMinimalAgeGate: 0 into the generated
app's .yarnrc.yml. The release-age gate is inappropriate for an ephemeral
e2e app that must install freshly-published SDK packages.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(e2e): Disable yarn 4 release-age gate only on yarn-4 test apps

The previous fix wrote npmMinimalAgeGate/enableHardenedMode unconditionally
into the generated app's .yarnrc.yml. That broke RN versions whose app pins
yarn 3 (e.g. 0.71.19): yarn 3 hard-errors on the unknown settings, and it has
no release-age gate to begin with. enableHardenedMode isn't even a valid
setting on the yarn the older apps use.

Probe whether the app's yarn supports npmMinimalAgeGate (yarn 4 exits 0,
yarn 3 exits 1) and only append npmMinimalAgeGate: 0 when supported. Verified
against yarn 3.6.4 and 4.17.0: the yarn-4 app clears the quarantine, the
yarn-3 app installs with a minimal yarnrc and no unknown-setting error.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(e2e): Disable yarn 4 release-age gate for ts3.8 type-check install

Same root cause as the e2e app fix, different location. run-type-check.sh
does a fresh `yarn install` after yalc-adding @sentry/react-native, which
re-resolves transitive @sentry/* deps. Under yarn 4, a just-published SDK
version (e.g. right after a JS SDK bump) is quarantined by npmMinimalAgeGate
(default 1 day, auto-enabled by hardened mode on public-PR CI) and fails the
install.

This workspace always runs on the repo's yarn 4, so pass
YARN_NPM_MINIMAL_AGE_GATE=0 inline to the install.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: antonis

.gitignore

@@ -107,3 +107,4 @@ samples/*/.env
 # Auto-generated by dotagents — do not commit these files.
 agents.lock
 .agents/.gitignore
+tsconfig.tsbuildinfo

.yarnrc.yml

@@ -1,3 +1,5 @@
+enableScripts: true
+
 nmHoistingLimits: workspaces
 
 nodeLinker: node-modules

dev-packages/e2e-tests/cli.mjs

@@ -160,7 +160,25 @@ if (actions.includes('create')) {
   fs.writeFileSync(appPackageJsonPath, JSON.stringify(appPackageJson, null, 2) + '\n');
 
   // original yarnrc contains the exact yarn version which causes corepack to fail to install yarn v3
-  fs.writeFileSync(`${appDir}/.yarnrc.yml`, 'nodeLinker: node-modules', { encoding: 'utf-8' });
+  fs.writeFileSync(`${appDir}/.yarnrc.yml`, 'nodeLinker: node-modules\n', { encoding: 'utf-8' });
+
+  // The generated app pins its own yarn version (varies by RN version: e.g. v3 for
+  // older RN, v4 for newer). yarn 4 quarantines any package newer than
+  // npmMinimalAgeGate (default 1 day) — and auto-enables that gate on public-PR CI —
+  // so a just-published first-party @sentry/* version (e.g. right after a JS SDK bump)
+  // resolved fresh from this app's empty lockfile fails the install. Disable the gate,
+  // but only when the app's yarn supports the setting: yarn 3 hard-errors on unknown
+  // settings, and it has no age gate to begin with. Probe support rather than guess a
+  // version threshold.
+  const appYarnSupportsAgeGate =
+    execSync(`yarn config npmMinimalAgeGate > /dev/null 2>&1; echo $?`, {
+      cwd: appDir,
+      env: env,
+      encoding: 'utf-8',
+    }).trim() === '0';
+  if (appYarnSupportsAgeGate) {
+    fs.appendFileSync(`${appDir}/.yarnrc.yml`, 'npmMinimalAgeGate: 0\n', { encoding: 'utf-8' });
+  }
   // yarn v3 won't install dependencies in a sub project without a yarn.lock file present
   fs.writeFileSync(`${appDir}/yarn.lock`, '');
 

dev-packages/type-check/run-type-check.sh

@@ -18,7 +18,13 @@ cd "${__dirpath}/ts3.8-test"
 yalc add @sentry/expo-upload-sourcemaps
 yalc add @sentry/react-native
 
-yarn install
+# Disable yarn 4's release-age gate for this fresh install. The yalc-linked
+# @sentry/react-native pulls transitive @sentry/* deps that get resolved fresh, so a
+# just-published SDK version (e.g. right after a JS SDK bump) would be quarantined
+# (default npmMinimalAgeGate is 1 day, and hardened mode auto-enables on public-PR CI)
+# and fail the install. This workspace always runs on the repo's yarn 4, so the
+# setting is always valid here.
+YARN_NPM_MINIMAL_AGE_GATE=0 yarn install
 
 # Re-add yalc packages to ensure they are in node_modules (yarn might have removed them)
 yalc add @sentry/expo-upload-sourcemaps

package.json

@@ -134,9 +134,10 @@
     "socks": "^2.8.8",
     "@appium/support@npm:7.0.6/uuid": "^13.0.1",
     "node-simctl@npm:8.1.6/uuid": "^13.0.1",
-    "shell-quote": "^1.8.4"
+    "shell-quote": "^1.8.4",
+    "downlevel-dts@npm:0.11.0/typescript": "5.9.3"
   },
   "version": "0.0.0",
   "name": "sentry-react-native",
-  "packageManager": "yarn@3.6.4+sha512.e70835d4d6d62c07be76b3c1529cb640c7443f0fe434ef4b6478a5a399218cbaf1511b396b3c56eb03bc86424cff2320f6167ad2fde273aa0df6e60b7754029f"
+  "packageManager": "yarn@4.17.0+sha512.c2957de2f9025ab14d63b24d0d8be1f1655810e22c341042c27f7ecd017b180ec12db73d69ac366d71b304ef9f069349ce462de96f04f8f1da317f4f762c95ae"
 }