fix(sdk): Set {{auto}} if user.ip_address is undefined
#4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
|
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native? |
krystofwoldrich
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
- Related to #15008 Export helpers to avoid duplications in sentry/react-native. - RN PR getsentry/sentry-react-native#4466
Yes, this depends on JS v9, which also means a major version of RN. |
timfish
reviewed
Feb 13, 2025
Comment on lines
+57
to
+58
| this.on('postprocessEvent', addAutoIpAddressToUser); | ||
| this.on('beforeSendSession', addAutoIpAddressToSession); |
There was a problem hiding this comment.
I think you only want to add these hooks if sendDefaultPii is true!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Tasks
{{auto}}to RN v5 or upgrade to JS v9❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
{{auto}}{{auto}}🛑 Blocked by JS v9
user.ip_addressexplicitly to{{auto}}sentry-javascript#15008 (mandatory to use the client hooks)💡 Motivation and Context
user.ip_address: {{auto}}team-sdks#118💚 How did you test it?
unit tests
📝 Checklist
sendDefaultPIIis enabled