fix(taskworker): Make using taskworker the default option (#97928)

If the options check fails, the system will default to celery. We are no
longer running celery workers, we should always use taskworkers

---------

Co-authored-by: Evan Hicks <[email protected]>

Author: enochtangg

src/sentry/options/defaults.py

@@ -3372,7 +3372,7 @@
 # Taskbroker flags
 register(
     "taskworker.enabled",
-    default=False,
+    default=True,
     flags=FLAG_AUTOMATOR_MODIFIABLE,
 )
 register(

tests/sentry/api/endpoints/test_project_codeowners_details.py

@@ -65,10 +65,10 @@ def test_basic_delete(self) -> None:
 
     @patch("django.utils.timezone.now")
     def test_basic_update(self, mock_timezone_now: MagicMock) -> None:
-        self.create_external_team(external_name="@getsentry/frontend", integration=self.integration)
-        self.create_external_team(external_name="@getsentry/docs", integration=self.integration)
         date = datetime(2023, 10, 3, tzinfo=timezone.utc)
         mock_timezone_now.return_value = date
+        self.create_external_team(external_name="@getsentry/frontend", integration=self.integration)
+        self.create_external_team(external_name="@getsentry/docs", integration=self.integration)
         raw = "\n# cool stuff comment\n*.js                    @getsentry/frontend @NisanthanNanthakumar\n# good comment\n\n\n  docs/*  @getsentry/docs @getsentry/ecosystem\n\n"
         data = {
             "raw": raw,

tests/sentry/issues/endpoints/test_project_codeowners_details.py

@@ -65,10 +65,10 @@ def test_basic_delete(self) -> None:
 
     @patch("django.utils.timezone.now")
     def test_basic_update(self, mock_timezone_now: MagicMock) -> None:
-        self.create_external_team(external_name="@getsentry/frontend", integration=self.integration)
-        self.create_external_team(external_name="@getsentry/docs", integration=self.integration)
         date = datetime(2023, 10, 3, tzinfo=timezone.utc)
         mock_timezone_now.return_value = date
+        self.create_external_team(external_name="@getsentry/frontend", integration=self.integration)
+        self.create_external_team(external_name="@getsentry/docs", integration=self.integration)
         raw = "\n# cool stuff comment\n*.js                    @getsentry/frontend @NisanthanNanthakumar\n# good comment\n\n\n  docs/*  @getsentry/docs @getsentry/ecosystem\n\n"
         data = {
             "raw": raw,

tests/sentry/relocation/tasks/test_process.py

@@ -416,9 +416,16 @@ def test_fail_no_org_slug_when_saas_to_saas(
         assert not RelocationFile.objects.filter(relocation=self.relocation).exists()
 
     # -1 minutes guarantees a timeout, even during synchronous execution.
-    @patch("sentry.relocation.tasks.process.CROSS_REGION_EXPORT_TIMEOUT", timedelta(minutes=-1))
+    @patch("sentry.relocation.tasks.process.CROSS_REGION_EXPORT_TIMEOUT", timedelta(minutes=0))
+    @patch(
+        "sentry.relocation.services.relocation_export.service.control_relocation_export_service.request_new_export"
+    )
     def test_fail_due_to_timeout(
-        self, uploading_complete_mock: Mock, fake_message_builder: Mock, fake_kms_client: Mock
+        self,
+        mock_export_service: Mock,
+        uploading_complete_mock: Mock,
+        fake_message_builder: Mock,
+        fake_kms_client: Mock,
     ):
         self.mock_message_builder(fake_message_builder)
         self.mock_kms_client(fake_kms_client)
@@ -441,7 +448,7 @@ def test_fail_due_to_timeout(
             assert relocation.status == Relocation.Status.FAILURE.value
             assert relocation.latest_notified == Relocation.EmailKind.FAILED.value
             assert relocation.failure_reason == ERR_UPLOADING_CROSS_REGION_TIMEOUT.substitute(
-                delta=timedelta(minutes=-1)
+                delta=timedelta(minutes=0)
             )
             assert fake_message_builder.call_count == 1
             assert fake_message_builder.call_args.kwargs["type"] == "relocation.failed"
@@ -452,6 +459,9 @@ def test_fail_due_to_timeout(
         assert fake_kms_client.return_value.get_public_key.call_count == 1
         assert fake_kms_client.return_value.asymmetric_decrypt.call_count == 0
 
+        # Verify that the export service was called but didn't complete successfully
+        assert mock_export_service.call_count == 1
+
         assert not RelocationFile.objects.filter(relocation=self.relocation).exists()
 
 

tests/sentry/tasks/test_code_owners.py

@@ -91,6 +91,8 @@ def test_codeowners_auto_sync_successful(
         self, mock_get_codeowner_file: MagicMock, mock_timezone_now: MagicMock
     ) -> None:
         with self.tasks() and self.feature({"organizations:integrations-codeowners": True}):
+            mock_now = datetime(2023, 1, 1, 0, 0, tzinfo=timezone.utc)
+            mock_timezone_now.return_value = mock_now
             self.create_external_team()
             self.create_external_user(external_name="@NisanthanNanthakumar")
             commit = Commit.objects.create(
@@ -105,8 +107,6 @@ def test_codeowners_auto_sync_successful(
                 filename=".github/CODEOWNERS",
                 type="A",
             )
-            mock_now = datetime(2023, 1, 1, 0, 0, tzinfo=timezone.utc)
-            mock_timezone_now.return_value = mock_now
             code_owners_auto_sync(commit.id)
 
         code_owners = ProjectCodeOwners.objects.get(id=self.code_owners.id)

tests/sentry/tasks/test_relay.py

@@ -136,11 +136,10 @@ def test_debounce(
 ):
     tasks = []
 
-    def apply_async(args, kwargs):
-        assert not args
+    def capture(task=None, args=None, kwargs=None):
         tasks.append(kwargs)
 
-    with mock.patch("sentry.tasks.relay.build_project_config.apply_async", apply_async):
+    with mock.patch("sentry.taskworker.task.Task._signal_send", side_effect=capture):
         schedule_build_project_config(public_key=default_projectkey.public_key)
         schedule_build_project_config(public_key=default_projectkey.public_key)
 

tests/sentry/workflow_engine/processors/test_detector.py

@@ -338,7 +338,11 @@ def test_doesnt_send_metric(self) -> None:
 
         with mock.patch("sentry.utils.metrics.incr") as mock_incr:
             process_detectors(data_packet, [detector])
-            mock_incr.assert_not_called()
+            # Ensure that mock_incr was not called with "workflow_engine.process_detector"
+            assert not any(
+                call[0][0] == "workflow_engine.process_detector"
+                for call in mock_incr.call_args_list
+            )
 
 
 @django_db_all