type src/sentry/api/helpers (#98013)

# Summary

Typed a new module, 11 files fixed.

# Test Plan

`mypy` no errors

Author: thetruecpaul

pyproject.toml

@@ -358,12 +358,7 @@ module = [
     "sentry.api.endpoints.project_rules_configuration",
     "sentry.api.endpoints.release_thresholds.*",
     "sentry.api.event_search",
-    "sentry.api.helpers.deprecation",
-    "sentry.api.helpers.environments",
-    "sentry.api.helpers.error_upsampling",
-    "sentry.api.helpers.group_index.delete",
-    "sentry.api.helpers.group_index.update",
-    "sentry.api.helpers.source_map_helper",
+    "sentry.api.helpers.*",
     "sentry.api.permissions",
     "sentry.api.serializers.models.organization_member.*",
     "sentry.api.serializers.rest_framework.group_notes",

src/sentry/api/bases/organization_events.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import itertools
-from collections.abc import Callable, Sequence
+from collections.abc import Callable, Iterable, Sequence
 from datetime import timedelta
 from typing import Any, cast
 from urllib.parse import quote as urlquote
@@ -115,7 +115,7 @@ def get_teams(self, request: Request, organization: Organization) -> list[Team]:
         if not request.user:
             return []
 
-        teams = get_teams(request, organization)
+        teams: Iterable[Team] = get_teams(request, organization)
         if not teams:
             teams = Team.objects.get_for_user(organization, request.user)
 

src/sentry/api/helpers/default_inbound_filters.py

@@ -1,17 +1,21 @@
+from collections.abc import Sequence
+
 from sentry.ingest import inbound_filters
+from sentry.models.organization import Organization
+from sentry.models.project import Project
 
 
 # Turns on certain inbound filters by default for project.
 def set_default_inbound_filters(
-    project,
-    organization,
-    filters=(
+    project: Project,
+    organization: Organization,
+    filters: Sequence[str] = (
         "browser-extensions",
         "legacy-browsers",
         "web-crawlers",
         "filtered-transaction",
     ),
-):
+) -> None:
 
     browser_subfilters = [
         "ie",

src/sentry/api/helpers/group_index/__init__.py

@@ -1,6 +1,7 @@
 from collections.abc import Callable, Mapping
 from typing import Any
 
+from sentry.models.group import Group
 from sentry.utils.cursors import CursorResult
 
 """TODO(mgaeta): This directory is incorrectly suffixed '_index'."""
@@ -16,7 +17,7 @@
 #  `sentry.api.paginator.BasePaginator.get_result`.
 SEARCH_MAX_HITS = 1000
 
-SearchFunction = Callable[[Mapping[str, Any]], tuple[CursorResult, Mapping[str, Any]]]
+SearchFunction = Callable[[Mapping[str, Any]], tuple[CursorResult[Group], Mapping[str, Any]]]
 
 __all__ = (
     "ACTIVITIES_COUNT",

src/sentry/api/helpers/group_index/validators/group.py

@@ -7,7 +7,7 @@
 from sentry.api.fields import ActorField
 from sentry.api.helpers.group_index.validators.inbox_details import InboxDetailsValidator
 from sentry.api.helpers.group_index.validators.status_details import StatusDetailsValidator
-from sentry.models.group import STATUS_UPDATE_CHOICES
+from sentry.models.group import STATUS_UPDATE_CHOICES, Group
 from sentry.types.actor import Actor
 from sentry.types.group import SUBSTATUS_UPDATE_CHOICES, PriorityLevel
 
@@ -23,7 +23,7 @@
         "snoozeDuration",
     ]
 )
-class GroupValidator(serializers.Serializer):
+class GroupValidator(serializers.Serializer[Group]):
     inbox = serializers.BooleanField(
         help_text="If true, marks the issue as reviewed by the requestor."
     )

src/sentry/api/helpers/group_index/validators/in_commit.py

@@ -13,7 +13,7 @@ class InCommitResult(TypedDict):
 
 
 @extend_schema_serializer()
-class InCommitValidator(serializers.Serializer):
+class InCommitValidator(serializers.Serializer[InCommitResult]):
     commit = serializers.CharField(required=True, help_text="The SHA of the resolving commit.")
     repository = serializers.CharField(
         required=True, help_text="The name of the repository (as it appears in Sentry)."

src/sentry/api/helpers/group_index/validators/inbox_details.py

@@ -1,6 +1,8 @@
+from typing import Never
+
 from rest_framework import serializers
 
 
-class InboxDetailsValidator(serializers.Serializer):
+class InboxDetailsValidator(serializers.Serializer[Never]):
     # Support undo / snooze reasons
     pass

src/sentry/api/helpers/group_index/validators/status_details.py

@@ -21,7 +21,7 @@ class StatusDetailsResult(TypedDict):
 
 
 @extend_schema_serializer()
-class StatusDetailsValidator(serializers.Serializer):
+class StatusDetailsValidator(serializers.Serializer[StatusDetailsResult]):
     inNextRelease = serializers.BooleanField(
         help_text="If true, marks the issue as resolved in the next release."
     )

src/sentry/api/helpers/releases.py

@@ -1,11 +1,15 @@
 from sentry.api.exceptions import ResourceDoesNotExist
 from sentry.models.grouplink import GroupLink
 from sentry.models.groupresolution import GroupResolution
+from sentry.models.organization import Organization
 from sentry.models.release import Release
 from sentry.models.releasecommit import ReleaseCommit
+from sentry.organizations.services.organization import RpcOrganization
 
 
-def get_group_ids_resolved_in_release(organization, version):
+def get_group_ids_resolved_in_release(
+    organization: Organization | RpcOrganization, version: str
+) -> set[int]:
     try:
         release = Release.objects.get(version=version, organization=organization)
     except Release.DoesNotExist:

src/sentry/api/helpers/slugs.py

@@ -20,7 +20,7 @@ def validate_sentry_slug(slug: str) -> None:
     validator(slug)
 
 
-def sentry_slugify(slug: str, allow_unicode=False) -> str:
+def sentry_slugify(slug: str, allow_unicode: bool = False) -> str:
     """
     Slugify a string using Django's built-in slugify function. Ensures that the
     slug is not entirely numeric by adding 3 letter suffix if necessary.