feat(hybridcloud) Fix silo issues in shared issue HTML view (#57978)

Add a small RPC service for handling the group share view HTML response.
We need to embed a small amount of group data into the HTML for embed
data. While in saas/multiregion setups we can use the subdomain to
locate the region and get the group, but in self-hosted we cannot so we
need to fallback to the monolith_region.

Refs HC-878

Author: markstory

src/sentry/models/group.py

@@ -294,7 +294,7 @@ def get_recommended_event_for_environments(
     return None
 
 
-class GroupManager(BaseManager):
+class GroupManager(BaseManager["Group"]):
     use_for_related_fields = True
 
     def by_qualified_short_id(self, organization_id: int, short_id: str):
@@ -541,7 +541,7 @@ class Group(Model):
     short_id = BoundedBigIntegerField(null=True)
     type = BoundedPositiveIntegerField(default=ErrorGroupType.type_id, db_index=True)
 
-    objects = GroupManager(cache_fields=("id",))
+    objects: GroupManager = GroupManager(cache_fields=("id",))
 
     class Meta:
         app_label = "sentry"

src/sentry/services/hybrid_cloud/issue/__init__.py

@@ -0,0 +1,40 @@
+# Please do not use
+#     from __future__ import annotations
+# in modules such as this one where hybrid cloud data models or service classes are
+# defined, because we want to reflect on type annotations and avoid forward references.
+
+
+from typing import Optional
+
+from sentry.models.group import Group
+from sentry.models.organization import Organization
+from sentry.services.hybrid_cloud.issue.model import RpcGroupShareMetadata
+from sentry.services.hybrid_cloud.issue.service import IssueService
+
+
+class DatabaseBackedIssueService(IssueService):
+    def get_shared_for_org(self, *, slug: str, share_id: str) -> Optional[RpcGroupShareMetadata]:
+        try:
+            organization = Organization.objects.get(slug=slug)
+        except Organization.DoesNotExist:
+            return None
+        if organization.flags.disable_shared_issues:
+            return None
+        try:
+            group = Group.objects.from_share_id(share_id)
+        except Group.DoesNotExist:
+            return None
+
+        return RpcGroupShareMetadata(title=group.title, message=group.message)
+
+    def get_shared_for_region(
+        self, *, region_name: str, share_id: str
+    ) -> Optional[RpcGroupShareMetadata]:
+        try:
+            group = Group.objects.from_share_id(share_id)
+        except Group.DoesNotExist:
+            return None
+        if group.organization.flags.disable_shared_issues:
+            return None
+
+        return RpcGroupShareMetadata(title=group.title, message=group.message)

src/sentry/services/hybrid_cloud/issue/impl.py

@@ -0,0 +1,6 @@
+from sentry.services.hybrid_cloud import RpcModel
+
+
+class RpcGroupShareMetadata(RpcModel):
+    title: str
+    message: str

src/sentry/services/hybrid_cloud/issue/model.py

@@ -0,0 +1,49 @@
+# Please do not use
+#     from __future__ import annotations
+# in modules such as this one where hybrid cloud data models or service classes are
+# defined, because we want to reflect on type annotations and avoid forward references.
+
+
+from abc import abstractmethod
+from typing import Optional, cast
+
+from sentry.services.hybrid_cloud.issue.model import RpcGroupShareMetadata
+from sentry.services.hybrid_cloud.region import ByOrganizationSlug, ByRegionName
+from sentry.services.hybrid_cloud.rpc import RpcService, regional_rpc_method
+from sentry.silo.base import SiloMode
+
+
+class IssueService(RpcService):
+    """
+    Avoid the temptation to expand this service.
+
+    We want as little access to issues and events in control as possible.
+
+    Unfortunately the issue public share link view requires it as
+    we need issue data to render the initial HTML so that open-graph
+    data can be included.
+    """
+
+    key = "issue"
+    local_mode = SiloMode.REGION
+
+    @classmethod
+    def get_local_implementation(cls) -> RpcService:
+        from sentry.services.hybrid_cloud.issue.impl import DatabaseBackedIssueService
+
+        return DatabaseBackedIssueService()
+
+    @regional_rpc_method(resolve=ByOrganizationSlug(), return_none_if_mapping_not_found=True)
+    @abstractmethod
+    def get_shared_for_org(self, *, slug: str, share_id: str) -> Optional[RpcGroupShareMetadata]:
+        pass
+
+    @regional_rpc_method(resolve=ByRegionName(), return_none_if_mapping_not_found=True)
+    @abstractmethod
+    def get_shared_for_region(
+        self, *, region_name: str, share_id: str
+    ) -> Optional[RpcGroupShareMetadata]:
+        pass
+
+
+issue_service = cast(IssueService, IssueService.create_delegation())

src/sentry/services/hybrid_cloud/issue/service.py

@@ -1,16 +1,24 @@
+from django.conf import settings
 from rest_framework.request import Request
 
-from sentry.models.group import Group
+from sentry.services.hybrid_cloud.issue.service import issue_service
+from sentry.web.frontend.base import control_silo_view
 from sentry.web.frontend.react_page import GenericReactPageView
 
 
+@control_silo_view
 class SharedGroupDetailsView(GenericReactPageView):
     def meta_tags(self, request: Request, share_id):
-        try:
-            group = Group.objects.from_share_id(share_id)
-        except Group.DoesNotExist:
-            return {}
-        if group.organization.flags.disable_shared_issues:
+        org_slug = getattr(request, "subdomain", None)
+        if org_slug:
+            group = issue_service.get_shared_for_org(slug=org_slug, share_id=share_id)
+        else:
+            # Backwards compatibility for Self-hosted and single tenants
+            group = issue_service.get_shared_for_region(
+                region_name=settings.SENTRY_MONOLITH_REGION, share_id=share_id
+            )
+
+        if not group:
             return {}
         return {
             "og:type": "website",

src/sentry/web/frontend/shared_group_details.py

@@ -28,6 +28,8 @@ const patterns: RegExp[] = [
   new RegExp('^api/0/sponsored_education_account/$'),
   new RegExp('^api/0/organizations/[^/]+/broadcasts/$'),
   new RegExp('^api/0/auth-details/$'),
+  new RegExp('^api/0/_admin/instance-level-oauth/$'),
+  new RegExp('^api/0/_admin/instance-level-oauth/[^/]+/$'),
   new RegExp('^_admin/'),
   new RegExp('^api/0/organizations/[^/]+/api-keys/$'),
   new RegExp('^api/0/organizations/[^/]+/api-keys/[^/]+/$'),
@@ -149,6 +151,7 @@ const patterns: RegExp[] = [
   new RegExp('^extensions/msteams/unlink-identity/[^/]+/$'),
   new RegExp('^extensions/discord/link-identity/[^/]+/$'),
   new RegExp('^extensions/discord/unlink-identity/[^/]+/$'),
+  new RegExp('^share/(?:group|issue)/[^/]+/$'),
 ];
 
 export default patterns;

static/app/data/controlsiloUrlPatterns.ts

@@ -914,6 +914,7 @@ def test_unresolves_group_with_auto_resolve(self, mock_is_resolved):
         assert event.group_id == event2.group_id
 
         group = Group.objects.get(id=event.group.id)
+        assert group.active_at
         assert group.active_at.replace(second=0) == event2.datetime.replace(second=0)
         assert group.active_at.replace(second=0) != event.datetime.replace(second=0)
 

tests/sentry/event_manager/test_event_manager.py

@@ -0,0 +1,68 @@
+from typing import Any
+
+from sentry.models.groupshare import GroupShare
+from sentry.silo.base import SiloMode
+from sentry.testutils.cases import TestCase
+from sentry.testutils.silo import assume_test_silo_mode, control_silo_test
+
+
+@control_silo_test(stable=True)
+class SharedGroupDetailsTest(TestCase):
+    def setUp(self):
+        self.group = self.create_group(project=self.project)
+        self.org_domain = f"{self.organization.slug}.testserver"
+
+    def share_group(self):
+        with assume_test_silo_mode(SiloMode.REGION):
+            return GroupShare.objects.create(
+                project=self.project, group=self.group, user_id=self.user.id
+            )
+
+    def assert_group_metadata_present(self, response: Any):
+        response_body = response.content.decode("utf8")
+        assert f'<meta property="og:title" content="{self.group.title}"' in response_body
+        assert f'<meta property="og:description" content="{self.group.message}"' in response_body
+        assert '<meta property="twitter:card" content="summary"' in response_body
+        assert f'<meta property="twitter:title" content="{self.group.title}"' in response_body
+        assert (
+            f'<meta property="twitter:description" content="{self.group.message}"' in response_body
+        )
+
+    def assert_group_metadata_absent(self, response: Any):
+        response_body = response.content.decode("utf8")
+        assert f'<meta property="og:title" content="{self.group.title}"' not in response_body
+        assert (
+            f'<meta property="og:description" content="{self.group.message}"' not in response_body
+        )
+        assert '<meta property="twitter:card" content="summary"' not in response_body
+        assert f'<meta property="twitter:title" content="{self.group.title}"' not in response_body
+        assert (
+            f'<meta property="twitter:description" content="{self.group.message}"'
+            not in response_body
+        )
+
+    def test_get_not_found(self):
+        response = self.client.get("/share/issue/lolnope/", HTTP_HOST=self.org_domain)
+        assert response.status_code == 200
+        self.assert_group_metadata_absent(response)
+
+    def test_get_org_disable_sharing(self):
+        share = self.share_group()
+        with assume_test_silo_mode(SiloMode.REGION):
+            self.organization.flags.disable_shared_issues = True
+            self.organization.save()
+        response = self.client.get(f"/share/issue/{share.uuid}/", HTTP_HOST=self.org_domain)
+        assert response.status_code == 200
+        self.assert_group_metadata_absent(response)
+
+    def test_get_no_subdomain(self):
+        share = self.share_group()
+        response = self.client.get(f"/share/issue/{share.uuid}/")
+        assert response.status_code == 200
+        self.assert_group_metadata_present(response)
+
+    def test_get_success(self):
+        share = self.share_group()
+        response = self.client.get(f"/share/issue/{share.uuid}/", HTTP_HOST=self.org_domain)
+        assert response.status_code == 200
+        self.assert_group_metadata_present(response)