Skip to content

Commit 9b45ee3

Browse files
ZylphrexAhmed-Labs
authored andcommitted
fix(tracemetrics): Properly fall back to high accuracy (#102828)
This would return 1 row with some null data so make sure to check the count is 0.
1 parent a4b1f51 commit 9b45ee3

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
} from 'sentry/views/explore/hooks/useProgressiveQuery';
1313
import type {TraceMetric} from 'sentry/views/explore/metrics/metricQuery';
1414
import {useMetricVisualize} from 'sentry/views/explore/metrics/metricsQueryParams';
15+
import {TraceMetricKnownFieldKey} from 'sentry/views/explore/metrics/types';
1516
import {
1617
useQueryParamsAggregateSortBys,
1718
useQueryParamsGroupBys,
@@ -32,6 +33,8 @@ interface MetricAggregatesTableResult {
3233
result: ReturnType<typeof useSpansQuery<any[]>>;
3334
}
3435

36+
const COUNT_AGGREGATE = `count(${TraceMetricKnownFieldKey.METRIC_NAME})`;
37+
3538
export function useMetricAggregatesTable({
3639
enabled,
3740
limit,
@@ -41,7 +44,10 @@ export function useMetricAggregatesTable({
4144
const canTriggerHighAccuracy = useCallback(
4245
(result: ReturnType<typeof useMetricAggregatesTableImp>['result']) => {
4346
const canGoToHigherAccuracyTier = result.meta?.dataScanned === 'partial';
44-
const hasData = defined(result.data) && result.data.length > 0;
47+
const hasData =
48+
defined(result.data) &&
49+
(result.data.length > 1 ||
50+
(result.data.length === 1 && Boolean(result.data[0][COUNT_AGGREGATE])));
4551
return !hasData && canGoToHigherAccuracyTier;
4652
},
4753
[]
@@ -97,7 +103,7 @@ function useMetricAggregatesTableImp({
97103
const discoverQuery: NewQuery = {
98104
id: undefined,
99105
name: 'Explore - Metric Aggregates',
100-
fields,
106+
fields: [...fields, COUNT_AGGREGATE],
101107
orderby: sortBys.map(formatSort),
102108
query,
103109
version: 2,

0 commit comments

Comments
 (0)