Skip to content

Commit e3b1b78

Browse files
authored
Revert "ref(metrics): Add metrics for script run times (#72223)" (#73447)
This reverts commit 09cdabf. Wasn't roll forwardable anyways since `make instlal-py-dev` goes through do.sh, which I plan on removing. Functionality will be preserved as part of getsentry/devenv#124 where span durations would work.
1 parent 0bcc2f9 commit e3b1b78

File tree

4 files changed

+2
-28
lines changed

4 files changed

+2
-28
lines changed

requirements-dev-frozen.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ rsa==4.8
178178
s3transfer==0.10.0
179179
selenium==4.16.0
180180
sentry-arroyo==2.16.5
181-
sentry-cli==2.32.0
181+
sentry-cli==2.16.0
182182
sentry-devenv==1.6.2
183183
sentry-forked-django-stubs==5.0.2.post4
184184
sentry-forked-djangorestframework-stubs==3.15.0.post1

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pytest-sentry>=0.3.0
1818
pytest-xdist>=3
1919
responses>=0.23.1
2020
selenium>=4.16.0
21-
sentry-cli>=2.32.0
21+
sentry-cli>=2.16.0
2222

2323
# pre-commit dependencies
2424
pre-commit>=3.3

scripts/do.sh

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,4 @@ source "${HERE}/lib.sh"
1313
# a venv can avoid enabling this by setting SENTRY_NO_VENV_CHECK
1414
[ -z "${SENTRY_NO_VENV_CHECK+x}" ] && eval "${HERE}/ensure-venv.sh"
1515
# If you call this script
16-
start=`date +%s`
1716
"$@"
18-
end=`date +%s`
19-
duration=$(($end-$start))
20-
21-
# If we're not in CI, send a metric of the script's execution time
22-
if [ -z "${CI+x}" ]; then
23-
configure-sentry-cli
24-
# DSN for `sentry-devservices` project in the Sentry SDKs org. Used as authentication for sentry-cli.
25-
export SENTRY_DSN=https://[email protected]/4507346183716864
26-
"${venv_name}"/bin/sentry-cli send-metric distribution -n script_execution_time -v $duration -u second -t script:$1
27-
fi

scripts/lib.sh

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,6 @@ require() {
3434
command -v "$1" >/dev/null 2>&1
3535
}
3636

37-
configure-sentry-cli() {
38-
if [ -f "${venv_name}/bin/sentry-cli" ]; then
39-
return 0
40-
elif [ -f "${venv_name}/bin/pip" ]; then
41-
pip-install sentry-cli
42-
else
43-
cat <<EOF
44-
${red}${bold}
45-
ERROR: sentry-cli could not be installed, please run "devenv sync".
46-
${reset}
47-
EOF
48-
return 1
49-
fi
50-
}
51-
5237
query-valid-python-version() {
5338
python_version=$(python3 -V 2>&1 | awk '{print $2}')
5439
if [[ -n "${SENTRY_PYTHON_VERSION:-}" ]]; then

0 commit comments

Comments
 (0)