better error reporting when execution of SQL fails because of temporary db creation errors

Author: gggeek

app/src/Command/DatabaseManagingCommand.php

@@ -11,6 +11,8 @@ abstract class DatabaseManagingCommand extends SQLExecutingCommand
      * @param array[] $dbSpecList key: db name (as used to identify configured databases), value: array('user': mandatory, 'dbname': mandatory, 'password': mandatory)
      * @return array 'succeeded': int, 'failed': int, 'results': same format as dbConfigurationManager::getInstanceConfiguration
      * @throws \Exception
+     *
+     * @todo make it easier to report back to the caller the errors that prevented creation of any DB
      */
     protected function createDatabases($instanceList, $dbSpecList)
     {
@@ -37,6 +39,11 @@ function ($schemaManager, $instanceName) use ($dbSpecList) {
         ///       (this could be achieved by copying the 'dbname' member over the 'servicename' one, or unsetting 'servicename'...)
         $finalData = [];
         foreach($results['data'] as $instanceName => $data) {
+            // check for failure in creation of temp db
+            // @todo how can we tell apart correctly errors that actually prevented the db from being created from other errors?
+            if (is_array($data) && isset($data['exitcode']) && $data['exitcode'] != 0) {
+                continue;
+            }
             $dbConnectionSpec = $dbSpecList[$instanceName];
             $finalData[$instanceName] = $instanceList[$instanceName];
             $finalData[$instanceName]['dbname'] = $dbConnectionSpec['dbname'];

app/src/Command/SQLExecutingCommand.php

@@ -182,6 +182,10 @@ protected function executeSqlAction($instanceList, $actionName, $getSqlActionCal
                     $results[$instanceName] = call_user_func($callable);
                     $succeeded++;
                 } catch (\Throwable $t) {
+                    $results[$instanceName] = [
+                        'exitcode' => $t->getCode(),
+                        'stderr' => $t->getMessage(),
+                    ];
                     $failed++;
                     $this->writeErrorln("\n<error>$actionName in instance '$instanceName' failed! Reason: " . $t->getMessage() . "</error>\n", OutputInterface::VERBOSITY_NORMAL);
                 }
@@ -201,8 +205,11 @@ protected function executeSqlAction($instanceList, $actionName, $getSqlActionCal
                             try {
                                 $output = call_user_func_array($outputFilters[$instanceName], [$output, $executors[$instanceName]]);
                             } catch (\Throwable $t) {
-                                /// @todo shall we reset $result to null or not?
-                                //$result = null;
+                                $output = [
+                                    // q: shall we add to the results the sql output ?
+                                    'exitcode' => $t->getCode(),
+                                    'stderr' => $t->getMessage(),
+                                ];
                                 $failed++;
                                 $succeeded--;
                                 $this->writeErrorln("\n<error>$actionName in instance '$instanceName' failed! Reason: " . $t->getMessage() . "</error>\n", OutputInterface::VERBOSITY_NORMAL);
@@ -212,14 +219,14 @@ protected function executeSqlAction($instanceList, $actionName, $getSqlActionCal
                         $succeeded++;
                     } else {
                         $err = trim($process->getErrorOutput());
+                        // some command-line database tools mix up stdout and stderr - we go out of our way to accommodate them...
+                        if ($err === '') {
+                            $err = trim($process->getOutput());
+                        }
                         $results[$instanceName] = [
                             'exitcode' => $process->getExitCode(),
                             'stderr' => $err,
                         ];
-                        // some command-line database tools mix up stdout and stderr - we go out of our way to accommodate them...
-                        if ($err === '') {
-                            $results[$instanceName]['stdout'] = $err = trim($process->getOutput());
-                        }
 
                         $failed++;
                         $this->writeErrorln("\n<error>$actionName in instance '$instanceName' failed! Reason: " . $err . "</error>\n", OutputInterface::VERBOSITY_NORMAL);

app/src/Command/SqlExecute.php

@@ -146,6 +146,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
                 foreach($instanceList as $instanceName  => $instanceSpecs) {
                     if (!isset($dbConnectionSpecs[$instanceName])) {
+                        /// @todo retrieve the actual temp db creation error instead of doing this...
+                        $results['data'][$instanceName] = [
+                            'exitcode' => '1',
+                            'stderr' => 'Error in creation of temporary database'
+                        ];
                         unset($instanceList[$instanceName]);
                     }
                 }