more unifor select results for postgres

Author: gggeek

app/src/Core/DatabaseSchemaManager.php

@@ -119,13 +119,13 @@ public function getDropDatabaseSqlAction($dbName, $userName, $ifExists = false)
 
             case 'mariadb':
             case 'mysql':
-                /// @todo since mysql 5.7, 'DROP USER IF EXISTS' is supported. We could use it...
-                $statements = [];
-                /// @todo test: does dropping the db first have an impact on dropping the user ?
+                $statements = [
+                    "DROP DATABASE {$ifClause} `$dbName`;"
+                ];
                 if ($userName != '') {
+                    /// @todo since mysql 5.7, 'DROP USER IF EXISTS' is supported. We could use it...
                     $statements[] = "DROP USER '$userName'@'%';";
                 }
-                $statements[] = "DROP DATABASE {$ifClause} `$dbName`;";
                 return new Command($statements);
 
             case 'mssql':
@@ -259,6 +259,7 @@ function ($output, $executor) {
             case 'sqlite':
                 return new Command(
                     null,
+                    /// @todo list the supported utf16 variants as soon as allow using them
                     function () {
                         return [];
                     }
@@ -394,7 +395,8 @@ function ($output, $executor) {
                 return new Command(
                     null,
                     function () {
-                        return [];
+                        // since sqlite does not support users, null seems more appropriate than an empty array...
+                        return null;
                     }
                 );
 
@@ -419,8 +421,6 @@ function ($output, $executor) {
                         /** @var Executor $executor */
                         $line = $executor->resultSetToArray($output)[0];
                         $parts = explode('|', $line);
-                        //preg_match('/version +\| +([^ ]+)/', $line, $matches);
-                        //return $matches[1];
                         return trim($parts[1]);
                     }
                 );

app/src/Core/SqlExecutor/Forked/NativeClient.php

@@ -71,7 +71,8 @@ public function getProcess($sqlOrFilename, $isFile = false)
                     $connectString .= $this->databaseConfiguration['dbname'];
                 }
                 $options = [
-                    $connectString
+                    $connectString,
+                    '-Pfooter=off'
                 ];
                 // NB: this triggers a different behaviour that piping multiple commands to stdin, namely
                 // it wraps all of the commands in a transaction and allows either sql commands or a single meta-command
@@ -176,7 +177,7 @@ public function resultSetToArray($string)
                 $output = explode("\n", $string);
                 array_shift($output); // headers
                 array_shift($output); // '---'
-                array_pop($output); // '(N rows)'
+                //array_pop($output); // '(N rows)'
                 foreach($output as &$line) {
                     $line = trim($line);
                 }

doc/TODO.md

@@ -1,7 +1,5 @@
 ## Fixes
 
-- check: regression w. mysql (& others) auto drop of users ? does it happen if sql execution fails ?
-
 - adminer:
   + can not connect to mariadb 5.5
   + sqllite not working in pre-filled list of databases (miss filename for root db)
@@ -75,9 +73,10 @@
   + test selecting a string with a | character in it =>
     + no client quotes it: to reliably parse columns we have to rely on tabular format, ie. measure header width...
     + sqllite in default output mode is even worse... (see below)
-  + test selecting string with length > 200 chars: ok
+  + try to have mssql use a smaller (but dynamic) col width for varchar results
   + investigate the possibility of having the clients emitting directly json results instead of plaintext
     + also: sqlite 3 has a more 'tabular' mode to display results, but it seems not to be able to calculate col. width automatically...
+  + test selecting string with length > 200 chars: ok
 
 - improve travis testing:
   + add tests:
@@ -104,6 +103,8 @@
 
 - build:
   + while setting up symfony, have the web site show up a courtesy page
+  + when there are no db data files, stack.sh should wait for the db instances to be fully ready...
+    (use docker native status monitoring to achieve this?)
   + add a composer post-upgrade script that downloads automatically the latest version of adminer or at least checks it
   + run security-checker as part of composer post-install and post-upgrade?
   + stack.sh: force usage of a random (or user-provided) pwd for db root account on startup
@@ -122,15 +123,18 @@
   + add a script that removes docker images and containers (eg. docker-compose down)
   + move from bash to sh ? also, reduce the number of cli commands we use (listed in readme)
   + add shell completion for commands of stack.sh
+  + add ./bin/dbconsole as alternative to './bin/stack.sh dbconsole' ?
 
 - worker: improve cli scripts
   + allow to drop many dbs, users in single commands
+  + add a user:create command which takes as option the list of dbs to grant access to
   + either remove ./vendor/bin/doctrine-dbal or make it actually work
   + make it possible to have uniform table formatting for SELECT-like queries
     - test with rows containing multiple cols, newlines, ...
     - sqlite might be problematic
   + when sorting instances, make mariadb_10 go after mariadb_5 and postgresql_10 go after postgresql_9
   + log by default php errors to /var/log/php and mount that dir on host ?
+  + add shell completion for commands of dbconsole
 
 - worker: sanitize sql execution cmd:
   + examine in detail and document the differences between running a command vs a file (eg. transaction usage)

doc/WHATSNEW.md

@@ -4,7 +4,7 @@ Version ?? (unreleased)
 - New: added dbconsole command: `user:drop`
 
 - Improved: results of SELECT commands are now displayed using table formatting for MariaDB and MySQL databases
-  when running dbconsole command `sql:execute`
+  when running dbconsole command `sql:execute`. Also, results for PostgeSQL databases are more terse (no more footer)
 
 - Improved: the `database:drop` command reports failures more consistently when trying to drop non-existing databases