Compile bug: Looking for C++ include rocwmma/rocwmma.hpp - not found

[AbdullahMPrograms]

Git commit

ef797db

Operating systems

Linux

GGML backends

HIP

Problem description & steps to reproduce

Im currently trying to build HIP with -DGGML_HIP_ROCWMMA_FATTN=ON on 2x W7900's.

rocwmma.hpp is clearly located at "/opt/rocm-6.4.1/include/rocwmma" but I repeatedly get "Looking for C++ include rocwmma/rocwmma.hpp - not found", I've also tried specifying -DCMAKE_CXX_FLAGS="-I/opt/rocm-6.4.1/include" and -DCMAKE_HIP_FLAGS="-I/opt/rocm-6.4.1/include"

First Bad Commit

No response

Compile command

cmake -B rocm -DGGML_HIP=ON -DGGML_HIP_ROCWMMA_FATTN=ON

Relevant log output

ultimis@ultimis-desktop:~/LLM/llama.cpp$ cmake -B rocm -DGGML_HIP=ON -DGGML_HIP_ROCWMMA_FATTN=ON
-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is GNU 13.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.43.0")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- ccache found, compilation results will be cached. Disable with GGML_CCACHE=OFF.
-- CMAKE_SYSTEM_PROCESSOR: x86_64
-- GGML_SYSTEM_ARCH: x86
-- Including CPU backend
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- x86 detected
-- Adding CPU backend variant ggml-cpu: -march=native
-- The HIP compiler identification is Clang 19.0.0
-- Detecting HIP compiler ABI info
-- Detecting HIP compiler ABI info - done
-- Check for working HIP compiler: /opt/rocm-6.4.1/lib/llvm/bin/clang++ - skipped
-- Detecting HIP compile features
-- Detecting HIP compile features - done
-- Looking for C++ include rocwmma/rocwmma.hpp
-- Looking for C++ include rocwmma/rocwmma.hpp - not found
-- HIP and hipBLAS found
-- Including HIP backend
-- ggml version: 0.0.5828
-- ggml commit:  ef797db3
-- Found CURL: /usr/lib/x86_64-linux-gnu/libcurl.so (found version "8.5.0")
-- Configuring done (3.0s)
-- Generating done (0.1s)
-- Build files have been written to: /home/ultimis/LLM/llama.cpp/rocm

[daniandtheweb]

I don't know if this is your case too but on my pc this seems more like a "visual" bug. In my case rocwmma.hpp is reported as not found but the program builds and manages to use it correctly.

[rohan-sircar]

@daniandtheweb is that so (that it's visual)? Been a while since I checked but I did get compilation failures even though rocwmma was in the right place

So... I created this patch and it worked fine for me, I've been using this in my build system ever since

diff --git a/ggml/src/ggml-hip/CMakeLists.txt b/ggml/src/ggml-hip/CMakeLists.txt
index 1fe8fe3b..9577203b 100644
--- a/ggml/src/ggml-hip/CMakeLists.txt
+++ b/ggml/src/ggml-hip/CMakeLists.txt
@@ -39,10 +39,12 @@ endif()
 find_package(hip     REQUIRED)
 find_package(hipblas REQUIRED)
 find_package(rocblas REQUIRED)
-if (GGML_HIP_ROCWMMA_FATTN)
-    CHECK_INCLUDE_FILE_CXX("rocwmma/rocwmma.hpp" FOUND_ROCWMMA)
-    if (NOT ${FOUND_ROCWMMA})
-        message(FATAL_ERROR "rocwmma has not been found")
+if(GGML_HIP_ROCWMMA_FATTN)
+    if(EXISTS "/opt/rocm-6.4.1/include/rocwmma/rocwmma.hpp")
+        set(FOUND_ROCWMMA TRUE)
+        include_directories(/opt/rocm-6.4.1/include)
+    else()
+        message(FATAL_ERROR "rocwmma.hpp not found at /opt/rocm-6.4.1/include/rocwmma/rocwmma.hpp")
     endif()
 endif()

Note: The space at the end is important!

@AbdullahMPrograms You can try this out
Save this as rocwmma.patch and use git apply rocwmma.patch to apply it and try building again, it should work

I had been contemplating on creating a PR for this for a while but didn't get around to it

Another note: Had to modify the patch for you to use /opt/rocm-6.4.1 because for me it's in /opt/rocm (I build it from source)