-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to no clear the search box when clicked outside #170
Comments
@erezrokah Yes. That sounds like a reasonable request. Are you interested in adding that functionality? |
Sure I can submit PR. Thanks @ghoshnirmalya! |
What is the status of this issue? @ghoshnirmalya |
Sorry @chstavridis, that's on me I haven't been able to submit a PR yet. We'll try to do it this week |
hi guys, any way to fix this! |
@alymkarimg I noticed that you created a PR and then closed it. Would you like to build that functionality? I can help. |
Hi, Yh, I’d love to help! I’ve also got one more bug that can’t be fixed
unless I change the search box to an uncontrolled component, would you be
free for a video call anytime in the near future!
Kind regards
Alym Karim
…On Fri, 13 Oct 2023 at 21:26, Nirmalya Ghosh ***@***.***> wrote:
@alymkarimg <https://github.com/alymkarimg> I noticed that you created a
PR <#180> and then
closed it. Would you like to build that functionality? I can help.
—
Reply to this email directly, view it on GitHub
<#170 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5GWCPZ3SUFDPPYKSZM5QTX7GPWVAVCNFSM6AAAAAAVNYK37OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSGE2TOMJSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thank you for this lovely component 🚀
At the moment when you click outside the search box the text is cleared:
react-search-box/src/hooks/use-outside-click.ts
Line 12 in af881e8
Are you open to add a configuration to control that behavior? Some users might prefer to keep the text they typed
The text was updated successfully, but these errors were encountered: