Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce toggle_macos_option_as_alt binding action #2520

Open
mitchellh opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2889
Open

Introduce toggle_macos_option_as_alt binding action #2520

mitchellh opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2889
Labels

Comments

@mitchellh
Copy link
Contributor

As discussed here: #2517

This is a feature of Terminal.app that seems worthwhile to add, both as a binding action and as a menu action to mimic Terminal.app. The default binding of option+command+O can also be copied from Terminal.app.

Since this is a binary toggle and macos-option-as-alt is not a binary configuration, I believe the behavior of the action should be as follows:

  1. Default the toggle to the value of the configuration. If macos-option-as-alt is true, it should show up checked.
  2. When untoggled, the value goes to false.
  3. When retoggled, the value returns back to the configured truthy value (if set) or true otherwise. This behavior lets the "on" behavior match what the user desired by default (left/right/true).

We should be clear in the documentation for the binding action how this behaves.

The discussion also noted a UI indication when this turns on and off. If we can get that in, that's great, but if not we can defer that to future work.

@nico nico linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant