Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: non-native fullscreen doesn't behave well with multiple fs windows #2927

Open
mitchellh opened this issue Dec 11, 2024 · 1 comment
Open
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor. gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos

Comments

@mitchellh
Copy link
Contributor

Follow up to #2516

While fixing #2516 (reviewing #2901), I realized there is another edge case that isn't handled well: when non-native full screen is entered from multiple windows, exiting non-native fs can incorrectly reactivate the menu and possibly the dock, making still-fullscreen windows look bad.

Reproduction

Specific steps to reproduce:

  1. Launch Ghostty with the config below.
  2. Open a new window (Cmd+N), now there are two windows, call them window A and B
  3. Fullscreen window A (Cmd+Enter)
  4. Move to window B (Cmd+Tilde)
  5. Fullscreen window B (Cmd+Enter)
  6. Move to window A (Cmd+Tilde)
  7. Exit fullscreen window A (Cmd+Enter)

Now notice that the dimensions for window B are messed up.

Config:

macos-non-native-fullscreen = true

Solution Thoughts

The solution here I think is to track globally (i.e. static) whether our NonNativeFullscreen implementation added the dock/menu presentation options and to only undo them on the final window.

cc @dzhlobo since you've found interest in this. 😄

@mitchellh mitchellh added contributor friendly A well-scoped, approachable issue for someone looking to contributor. gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos labels Dec 11, 2024
@liby
Copy link
Contributor

liby commented Feb 2, 2025

Unable to reproduce in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly A well-scoped, approachable issue for someone looking to contributor. gui GUI or app issue regardless of platform (i.e. Swift, GTK) os/macos
Projects
None yet
Development

No branches or pull requests

2 participants