Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick terminal splits get 1px out of sync with aggressive resizing #2944

Open
JakeWharton opened this issue Dec 12, 2024 · 7 comments
Open
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) needs-confirmation A reproduction has been reported, but the bug hasn't been confirmed or reproduced by a maintainer. os/macos

Comments

@JakeWharton
Copy link

I'm on macOS 14.7.1 (23H222) with Ghostty 9f75d93.

My full config is

initial-window = false
copy-on-select = true
window-save-state = always
background-opacity = 0.9
background-blur-radius = 5
window-step-resize = true
keybind = global:alt+grave_accent=toggle_quick_terminal
mouse-hide-while-typing = true
macos-option-as-alt = true

I tend to keep the quick terminal split into two panes. Aggressive resizing causes them to get 1px out of sync in terms of height:

Image

split.mov

Hiding and re-showing the quick terminal fixes this misalignment.

This issue occurs regardless of the window-step-resize = true settings.

@mitchellh mitchellh added the needs-confirmation A reproduction has been reported, but the bug hasn't been confirmed or reproduced by a maintainer. label Dec 13, 2024
@mitchellh
Copy link
Contributor

Well that is extremely bizarre. It's not like we're setting the pixel-level height of the view lol, this is just a SwiftUI-contained view hierarchy. I didn't confirm it yet but I certainly see it in the video. Also very odd that hiding and re-showing fixes it, I'll have to think about all that.

@mitchellh mitchellh added os/macos gui GUI or app issue regardless of platform (i.e. Swift, GTK) labels Dec 13, 2024
@blychs
Copy link

blychs commented Dec 26, 2024

I just attempted to reproduce this in MacOS (14.6.1) and the default config and could not. It looks as expected, without the weird mismatch

@JakeWharton
Copy link
Author

With 1.0.0 release, I'm unfortunately still able to repro:

Image

@mitchellh
Copy link
Contributor

Thanks. I’ve done nothing to try to solve this yet. I haven’t yet been able to reproduce it.

@JakeWharton
Copy link
Author

JakeWharton commented Dec 27, 2024

Yeah not a big deal. It's extremely low priority, and hopefully not even your problem but something in SwiftUI/AppKit or wherever. Mostly just confirming that I can still repro it with wildly-aggressive resizing (which is not at all like the resizing that I expect 99.99% of people to do). I don't even do such resizing normally–it was only when I was testing my TUI framework's parsing of in-band resizing notifications that caused me to discover it…

@albinkc
Copy link

albinkc commented Jan 2, 2025

Not sure if related but had this splitting at title-bar with zero config [video is normal speed]. Funnily enough, could not replicate when resizing from the left side.

Ghostty 1.0.1

Screen.Recording.mov

@albinkc
Copy link

albinkc commented Jan 3, 2025

Here's another one.

shell-integration = zsh
cursor-click-to-move = true
Screen.Recording.2.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui GUI or app issue regardless of platform (i.e. Swift, GTK) needs-confirmation A reproduction has been reported, but the bug hasn't been confirmed or reproduced by a maintainer. os/macos
Projects
None yet
Development

No branches or pull requests

4 participants