Colorized macOS icon doesn't render certain colors correctly

[qwerasd205]

When trying to set the screen color of the macOS icon to bright or desaturated colors, the resulting color is wrong. Similarly it's impossible to make the ghost dark.

I suspect the logic for tinting the elements isn't ideal - a bad choice of blend modes or something. I can investigate this at some point to try to improve it, or see about moving this to the Zig end of things and improve it in the process.

Examples:

screen	ghost	result
#FFFFFF	#000000
#FF88FF	#010101
#FFFF00	#105010
#7799FF	#4000A0

[qwerasd205]

Yeah so right now, you can't make them have a different luminance than the base value, since they're blended with the "color" blend mode. It would make more sense (IMO) to adjust the base images such that their brightest points are pure white, and then use a multiply blend mode, so that the brightest points are the specified color, alternatively we could experiment with a blend mode like overlay or soft light to see if it gives better results, but the point is: use a blend mode that allows the color to affect the luminance.

[mitchellh]

The blending used right now is the same used in the original psd for the Ghostty official icon. It may not work for all colors that's for sure. Would love to see this improved.

[nickkadutskyi]

I don't know if those are related but here is another issue #3215 (comment) where setting screen color in theme file doesn't work while work as expected if set in config file.