Introduce font-shaping-break config option
#5374
Open
+411
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-kat
reviewed
Feb 25, 2025
| /// Where to break font shaping runs. | ||
| /// | ||
| /// Currently only one option, "cursor", which is enabled by default and breaks | ||
| /// text runs under the cursor. |
There was a problem hiding this comment.
I don't know about you, but I personally would have no idea what “text runs” are. Perhaps an example (e.g. #4469) would be warranted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the config option as described in #4515.
Plumbed it into the
RunIteratorand updated all the tests that rely on that, adding additional cases to the cursor boundary tests where I found them.Closes #4515