-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Ctrl+L with Ergo-L keyboard layout doesn't produce a ctrl encoding #5448
Comments
The line you mention above ( Commenting out that line and doing a fresh build solved that for me, so seems to be not only related to Ergo-L. But as you mentioned, probably the removal of Though I'm actually using a Capslock key mapped onto Tab, you can set that up in macOS System Settings via Customise modifier keys. |
Hello! I am using Ergo-L on macOS and I can confirm that I have lost all the usual |
Can confirm the same issue when using latest version of Ghostty with workman keyboard layout. So not just isolated to Ergo-L. |
qwerty-lafayette here, I can confirm the same for any |
+1, version 1.1.0 of Ghostty is not really usable with Workman layout. Here's how I downgraded to 1.0.1: cd ~/Downloads/
curl https://raw.githubusercontent.com/Homebrew/homebrew-cask/99378d4eaa63a12947b8eccd526a6d9d27564cce/Casks/g/ghostty.rb > ghostty.rb
brew uninstall ghostty && brew install --cask ./ghostty.rb |
P.S.: "I also have this issue"1/"Please fix it!"/"Will this be fixed"2 type posts aren't helpful and send an unnecessary email notification to all subscribers; consider using the 👍 reaction instead :) Footnotes
|
Fixes #5448 We previously removed the ctrl modifier for text commit (IME-style) to workaround a libghostty quirk (as noted in the comment in the diff). But this broke other keyboard layouts. This commit attempts to clean this up slightly -- but not completely -- by removing that hack, and only modifying the ctrl behavior for the UCKeyTranslate call. Long term, I plan to remove UCKeyTranslate completely, as noted in the todo comment already written just below this diff. This fixes the aforementioned issue and hopefully doesn't regress any other behavior. I tested the following: 1. Dvorak Ctrl characters 2. Ergo-L Ctrl characters 3. US standard Ctrl characters 4. Japanese IME input Ctrl input to modify IME state
Fixes #5448 We previously removed the ctrl modifier for text commit (IME-style) to workaround a libghostty quirk (as noted in the comment in the diff). But this broke other keyboard layouts. This commit attempts to clean this up slightly -- but not completely -- by removing that hack, and only modifying the ctrl behavior for the UCKeyTranslate call. Long term, I plan to remove UCKeyTranslate completely, as noted in the todo comment already written just below this diff. This fixes the aforementioned issue and hopefully doesn't regress any other behavior. I tested the following: 1. Dvorak Ctrl characters 2. Ergo-L Ctrl characters 3. US standard Ctrl characters 4. Japanese IME input Ctrl input to modify IME state
@mitchellh, after installing Ghostty version 1.1.1, I lost my Nvim motions involving ctrl. |
I'm looking into this now, please go to #5743 |
Steps to reproduce:
kitty +kitten show_key -m kitty
(or any other)Notice the control key doesn't show up.
I've tracked this down to the code below, but this code exists for a reason. We should investigate why we do this, fix this, and ensure we don't regress the reason we did this in the first place.
ghostty/macos/Sources/Ghostty/SurfaceView_AppKit.swift
Lines 853 to 858 in c5508e7
The text was updated successfully, but these errors were encountered: