[macOS] feat: Add "quick-terminal" option to "macos-hidden" config #5803
Conversation
McNight
force-pushed
the
mcnight/quick_terminal_macos_hidden
branch
from
929d8ea to
5b77807
Compare
McNight
force-pushed
the
mcnight/quick_terminal_macos_hidden
branch
from
5b77807 to
d7a7da6
Compare
| @@ -5762,6 +5762,7 @@ pub const MacTitlebarProxyIcon = enum { | |||
| pub const MacHidden = enum { | |||
| never, | |||
| always, | |||
| @"quick-terminal", | |||
There was a problem hiding this comment.
Oh we need to add docs for this to the config key in this file.
There was a problem hiding this comment.
I added a comment for this new case, but maybe all the related paragraphs above need to be updated as well?
| @@ -403,6 +403,10 @@ class AppDelegate: NSObject, | |||
| reloadDockMenu() | |||
| } | |||
|
|
|||
| func applicationDidUpdate(_ notification: Notification) { | |||
There was a problem hiding this comment.
Okay I tested the logic of this and imo this callback gets called way too much. On initial launch it's called 4 times and when I close the window once it gets called something like a dozen or more times (I didn't count, but it was a lot).
I think we need to do something different. Maybe "any open window" isn't the right logic and we need to do some more research into how iTerm2 behaves instead.
There was a problem hiding this comment.
Yes that's what I noticed as well :/
I saw this method from a blog post about the challenge to track managed windows...
With AppKit Notifications, you get one when a window is about to close, and when one is becoming key/main but that's it.
Maybe we could intercept (via swizzling?) when windows are about to be set to the NSApp.windows property; or even add KVO to it (because it is not unfortunately)...
Do you think that applicationDidUpdate(_:) may cause performance issues?
There was a problem hiding this comment.
Do you think that applicationDidUpdate(_:) may cause performance issues?
I'm not sure if it'll practically cause issues but I'm afraid it'll cause unnecessary CPU/power usage. I'm not sure how grounded in reality that is but for a feature this minor it doesn't seem worth it.
mitchellh
added
the
feedback-requested
Fixes #5784
I started with a notification for listening to Ghostty terminal windows but then I saw the remark about update windows so I implemented
applicationDidUpdatewhich is called whenever a window is added/removed.Tell me if if you want me to remove the notification for Ghostty terminals!