Skip to content
This repository was archived by the owner on Jan 26, 2023. It is now read-only.

Commit f74832c

Browse files
authored
Merge pull request #368 from gitcoinco/hopsoft/341/remove-app-signal
Remove AppSignal instrumentation
2 parents 0023c0d + 5d7a35f commit f74832c

File tree

9 files changed

+3
-24
lines changed

9 files changed

+3
-24
lines changed

config/config.exs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,7 @@ config :code_fund, CodeFundWeb.Endpoint,
2626
url: [host: System.get_env("HOST") || "localhost"],
2727
secret_key_base: "JdaDMqC6DEzZP5Mjm9S06nVaLaqExfN3Tyszbywe9c99Sg6RA2h7nRCVB2LFBN1n",
2828
render_errors: [view: CodeFundWeb.ErrorView, accepts: ~w(html json)],
29-
pubsub: [name: CodeFund.PubSub, adapter: Phoenix.PubSub.PG2],
30-
instrumenters: [Appsignal.Phoenix.Instrumenter]
31-
32-
config :phoenix, :template_engines,
33-
eex: Appsignal.Phoenix.Template.EExEngine,
34-
exs: Appsignal.Phoenix.Template.ExsEngine
29+
pubsub: [name: CodeFund.PubSub, adapter: Phoenix.PubSub.PG2]
3530

3631
config :code_fund, Framework.FileStorage,
3732
cdn_host: System.get_env("CDN_HOST") || "d2nhukomolqgak.cloudfront.net"

config/configs/appsignal.exs

Lines changed: 0 additions & 8 deletions
This file was deleted.

config/dev.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ config :code_fund, CodeFund.Repo,
4141
hostname: System.get_env("POSTGRES_HOST") || "localhost",
4242
database: "code_fund_dev",
4343
pool_size: 10,
44-
loggers: [Appsignal.Ecto, Ecto.LogEntry]
44+
loggers: [Ecto.LogEntry]
4545

4646
config :code_fund, CodeFund.Mailer, adapter: Bamboo.LocalAdapter
4747

config/prod.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ config :code_fund, CodeFund.Repo,
2222
url: System.get_env("DATABASE_URL"),
2323
pool_size: String.to_integer(System.get_env("POOL_SIZE") || "10"),
2424
ssl: true,
25-
loggers: [Appsignal.Ecto, Ecto.LogEntry]
25+
loggers: [Ecto.LogEntry]
2626

2727
config :redix,
2828
host: System.get_env("REDIS_HOST"),

config/test.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ config :ex_aws, :s3,
3535
host: "localhost",
3636
port: 4567
3737

38-
config :appsignal, :config, active: false
3938
config :time_machinex, TimeMachinex, adapter: TimeMachinex.ManagedClock
4039

4140
config :code_fund, AdService.Tracking.AnalyticsManager,

lib/code_fund/impressions/impressions.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@ defmodule CodeFund.Impressions do
9292
9393
"""
9494
def create_impression(attrs \\ %{}) do
95-
Appsignal.increment_counter("impressions.create", 1)
96-
9795
%Impression{}
9896
|> Impression.changeset(attrs)
9997
|> Repo.insert()

lib/code_fund_web.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ defmodule CodeFundWeb do
9898
def endpoint do
9999
quote do
100100
use Phoenix.Endpoint, otp_app: :code_fund
101-
use Appsignal.Phoenix
102101
use Sentry.Phoenix.Endpoint
103102
end
104103
end

lib/code_fund_web/controllers/track_controller.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ defmodule CodeFundWeb.TrackController do
4242
impression
4343
|> Impressions.update_impression(update_attributes)
4444

45-
Appsignal.increment_counter("impressions.clicks.count", 1)
46-
4745
redirect(conn, external: update_attributes.redirected_to_url)
4846
end
4947

mix.exs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ defmodule CodeFund.Mixfile do
4545
:corsica,
4646
:bamboo,
4747
:phoenix_html_simplified_helpers,
48-
:appsignal,
4948
:mailchimp
5049
]
5150
]
@@ -104,7 +103,6 @@ defmodule CodeFund.Mixfile do
104103
{:bamboo, "~> 0.8"},
105104
{:ex_image_info, "~> 0.2.3"},
106105
{:phoenix_html_simplified_helpers, "~> 2.0.1"},
107-
{:appsignal, "~> 1.0"},
108106
{:time_machinex, "~> 0.1.0"},
109107
{:mailchimp, "~> 0.0.7"},
110108
{:mock, "~> 0.3.0", only: :test},

0 commit comments

Comments
 (0)