Rust: Remove getMethodName from Call

Author: hvitved

rust/ql/lib/codeql/rust/elements/internal/CallImpl.qll

@@ -34,9 +34,6 @@ module Impl {
    * called in Rust.
    */
   abstract class Call extends ExprImpl::Expr {
-    /** Gets the name of the method called if this call is a method call. */
-    abstract string getMethodName();
-
     /** Gets the argument at the given position, if any. */
     abstract Expr getArgument(ArgumentPosition pos);
 
@@ -87,8 +84,6 @@ module Impl {
   class CallExprCall extends Call instanceof CallExpr {
     CallExprCall() { not callIsMethodCall(this, _, _, _) }
 
-    override string getMethodName() { none() }
-
     override Expr getArgument(ArgumentPosition pos) {
       result = super.getArgList().getArg(pos.asPosition())
     }
@@ -107,8 +102,6 @@ module Impl {
      */
     predicate hasExplicitSelfBorrow() { selfIsRef = true }
 
-    override string getMethodName() { result = methodName }
-
     override Expr getArgument(ArgumentPosition pos) {
       pos.isSelf() and result = super.getArgList().getArg(0)
       or
@@ -117,8 +110,6 @@ module Impl {
   }
 
   private class MethodCallExprCall extends Call instanceof MethodCallExpr {
-    override string getMethodName() { result = super.getIdentifier().getText() }
-
     override Expr getArgument(ArgumentPosition pos) {
       pos.isSelf() and result = this.(MethodCallExpr).getReceiver()
       or
@@ -133,8 +124,6 @@ module Impl {
 
     OperatorCall() { super.isOverloaded(trait, methodName, borrows) }
 
-    override string getMethodName() { result = methodName }
-
     override Expr getArgument(ArgumentPosition pos) {
       pos.isSelf() and result = super.getOperand(0)
       or
@@ -143,8 +132,6 @@ module Impl {
   }
 
   private class IndexCall extends Call instanceof IndexExpr {
-    override string getMethodName() { result = "index" }
-
     override Expr getArgument(ArgumentPosition pos) {
       pos.isSelf() and result = super.getBase()
       or

rust/ql/lib/codeql/rust/internal/TypeInference.qll

@@ -1710,7 +1710,7 @@ private module MethodResolution {
   final class MethodCallOperation extends MethodCall, Operation {
     pragma[nomagic]
     override predicate hasNameAndArity(string name, int arity) {
-      name = this.(Call).getMethodName() and
+      this.isOverloaded(_, name, _) and
       arity = this.getNumberOfOperands() - 1
     }