Skip to content

Commit 3dcd81a

Browse files
authored
Merge pull request #36 from github/closing-fixes
Closing Fixes
2 parents a73e17e + 15d7904 commit 3dcd81a

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

__tests__/main.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ test('successfully runs the action', async () => {
158158
expect(infoMock).toHaveBeenCalledWith('Merged branch dependabot-5')
159159
expect(infoMock).toHaveBeenCalledWith('Creating combined PR')
160160
expect(debugMock).toHaveBeenCalledWith(
161-
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- #1 Update dependency 1\n- #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
161+
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- Closes #1 Update dependency 1\n- Closes #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
162162
)
163163
expect(infoMock).toHaveBeenCalledWith(
164164
'Combined PR url: https://github.com/test-owner/test-repo/pull/100'
@@ -225,7 +225,7 @@ test('successfully runs the action with the branch_regex option', async () => {
225225
expect(infoMock).toHaveBeenCalledWith('Merged branch dependabot-5')
226226
expect(infoMock).toHaveBeenCalledWith('Creating combined PR')
227227
expect(debugMock).toHaveBeenCalledWith(
228-
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- #1 Update dependency 1\n- #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
228+
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- Closes #1 Update dependency 1\n- Closes #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
229229
)
230230
expect(infoMock).toHaveBeenCalledWith(
231231
'Combined PR url: https://github.com/test-owner/test-repo/pull/100'
@@ -780,7 +780,7 @@ test('successfully runs the action and sets labels', async () => {
780780
expect(infoMock).toHaveBeenCalledWith('Merged branch dependabot-5')
781781
expect(infoMock).toHaveBeenCalledWith('Creating combined PR')
782782
expect(debugMock).toHaveBeenCalledWith(
783-
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- #1 Update dependency 1\n- #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
783+
'PR body: # Combined PRs ➡️📦⬅️\n\n✅ The following pull requests have been successfully combined on this PR:\n- Closes #1 Update dependency 1\n- Closes #5 Update dependency 5\n\n⚠️ The following PRs were left out due to merge conflicts:\n- #2 Update dependency 2\n\n> This PR was created by the [`github/combine-prs`](https://github.com/github/combine-prs) action'
784784
)
785785

786786
expect(infoMock).toHaveBeenCalledWith(

dist/index.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export async function run() {
137137
combinedPRs.push(prString)
138138
} catch (error) {
139139
core.warning('Failed to merge branch ' + branch)
140-
mergeFailedPRs.push(prString)
140+
mergeFailedPRs.push(prString.replace('Closes ', ''))
141141
}
142142
}
143143

0 commit comments

Comments
 (0)