config: remove dead server type re-normalization in convertStdinServerConfig

[Copilot]

convertStdinServerConfig duplicated the "" → "stdio" and "local" → "stdio" normalization already performed (with mutation) by validateServerConfigWithCustomSchemas, making those guards unreachable dead code.

Changes

• internal/config/config_stdin.go: Removed the 7-line dead normalization block; replaced with a direct assignment and a comment explaining that server.Type is already canonical after validation.

// Before
serverType := server.Type
if serverType == "" {      // never true — validator already defaulted to "stdio"
    serverType = "stdio"
}
if serverType == "local" { // never true — validator already normalized to "stdio"
    serverType = "stdio"
}

// After
// server.Type has been normalized to "stdio", "http", or a custom type by
// validateServerConfigWithCustomSchemas above; no re-normalization is needed here.
serverType := server.Type

The comment anchors the invariant so future maintainers don't re-introduce the pattern.

[Copilot]

Pull request overview

Removes dead, unreachable server type normalization logic from the JSON-stdin conversion path, relying on the canonicalization already performed (with mutation) during server config validation.

Changes:

• Removed redundant "" → "stdio" and "local" → "stdio" normalization from convertStdinServerConfig.
• Added an inline comment documenting the post-validation invariant for server.Type.

Show a summary per file

File	Description
internal/config/config_stdin.go	Removes unreachable type re-normalization and documents that validation canonicalizes server.Type before conversion.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[lpcox]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved. The only conflict was a comment-only difference in config_stdin.go between this branch and main — adopted main's wording. Merged in 24c3508, all checks pass.