[repository-quality] Repository Quality Improvement Report - Context Propagation & Process Cancellability (Reuse Run)

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Context Propagation & Process Cancellability

Analysis Date: 2026-06-22
Focus Area: Context Propagation & Process Cancellability
Strategy Type: Reuse (random=95, 10% tier)
Custom Area: No — highest-impact area; original 2026-06-03 (high: 3), confirmed zero progress 2026-06-09

Executive Summary

exec.CommandContext adoption grew from 18% → 23.9% since June 9: run_push.go was fixed (4 git ops now use CommandContext) and the execcommandwithoutcontext linter was added. These are meaningful wins.

102 bare exec.Command calls remain in production source. The linter guards new ctx-receiving functions, but cannot force ctx threading into utility functions that don't yet accept ctx. The biggest gaps are pkg/cli/git.go (18 calls, 8 uncancellable git utilities), pkg/cli/pr_command.go (20 calls in applyPatchToRepo), and pkg/cli/trial_helpers.go (5 calls in copyTrialResultsToHostRepo). One active linter violation also exists in remote_fetch.go:628.

Full Analysis Report

Current State Assessment

Metric	Value	Status
Bare exec.Command (non-test, non-testdata)	102	⚠️
exec.CommandContext (non-test, non-testdata)	32	✅
Adoption rate	23.9% (↑ from 18%)	⚠️
Linter violations in ctx-receiving functions	1 confirmed	❌
run_push.go fixed since June 9	yes	✅
execcommandwithoutcontext linter active	yes	✅

Progress since 2026-06-09:

• pushWorkflowFiles in pkg/cli/run_push.go — FIXED (4 git ops use CommandContext) ✅
• execcommandwithoutcontext linter registered in cmd/linters/main.go + spec_test.go ✅
• 10 additional CommandContext call sites added

Findings

Strengths

• run_push.go is now fully context-aware
• execcommandwithoutcontext linter prevents new violations in ctx-receiving functions
• mcp_inspect_mcp.go already correctly uses exec.CommandContext for both docker and command paths

Areas for Improvement

• [HIGH] pkg/parser/remote_fetch.go:628 — active linter violation: downloadFileViaGit(ctx, ...) calls bare exec.Command("git", "archive", ...) — one-line fix
• [HIGH] pkg/cli/git.go — 18 bare exec.Command across 8 functions with no ctx param; all called from ctx-aware callers
• [MEDIUM] pkg/cli/trial_helpers.go:282 — copyTrialResultsToHostRepo (5 bare calls) invoked from executeTrialRun(ctx, ...) without threading ctx
• [MEDIUM] pkg/cli/pr_command.go:257 — applyPatchToRepo (20 bare calls); transferPR caller also lacks ctx

Detailed Analysis

pkg/cli/git.go gap summary:
Functions createAndSwitchBranch, switchBranch, commitChanges, pushBranch, checkCleanWorkingDirectory, stageAllChanges, stageWorkflowChanges, ensureGitAttributes — 18 bare exec.Command calls total, called from pkg/cli/pr_helpers.go which is already invoked with cobra cmd.Context().

Active linter violation in remote_fetch.go:

// line 600 — ctx received
func downloadFileViaGit(ctx context.Context, owner, repo, path, ref, host string) ([]byte, error) {
    // ...
    // line 628 — VIOLATION: ctx ignored
    cmd := exec.Command("git", "archive", "--remote="+repoURL, ref, path)
    // fix: exec.CommandContext(ctx, "git", "archive", ...)

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Fix Active Linter Violation in downloadFileViaGit

Priority: High
Estimated Effort: Small
Focus Area: Context Propagation

Description: downloadFileViaGit in pkg/parser/remote_fetch.go receives ctx but calls bare exec.Command("git", "archive", ...) at line 628.

Acceptance Criteria:

• exec.Command("git", "archive", ...) at line 628 → exec.CommandContext(ctx, "git", "archive", ...)
• #nosec G204 comment preserved
• make lint passes

Code Region: pkg/parser/remote_fetch.go:628

---

Task 2: Add ctx to pkg/cli/git.go Utility Functions

Priority: High
Estimated Effort: Large
Focus Area: Context Propagation

Description: 8 git utility functions in pkg/cli/git.go have 18 bare exec.Command calls and no ctx parameter. All are called from cobra RunE handlers (which have cmd.Context()) via pkg/cli/pr_helpers.go.

Acceptance Criteria:

• createAndSwitchBranch, switchBranch, commitChanges, pushBranch, checkCleanWorkingDirectory, stageAllChanges, stageWorkflowChanges, ensureGitAttributes gain ctx context.Context first parameter
• All 18 bare exec.Command → exec.CommandContext(ctx, ...)
• Callers in pr_helpers.go and add_interactive_git.go updated to pass ctx
• make lint and make test pass

Code Region: pkg/cli/git.go, pkg/cli/pr_helpers.go

---

Task 3: Thread ctx Through copyTrialResultsToHostRepo

Priority: Medium
Estimated Effort: Small
Focus Area: Context Propagation

Description: copyTrialResultsToHostRepo in pkg/cli/trial_helpers.go (line 282) has 5 bare exec.Command git operations. Called from executeTrialRun(ctx, ...) at line 183 without passing ctx.

Acceptance Criteria:

• copyTrialResultsToHostRepo gains ctx context.Context first parameter
• All 5 bare exec.Command → exec.CommandContext(ctx, ...)
• Call site at line 183 passes ctx
• make lint and make test pass

Code Region: pkg/cli/trial_helpers.go:282

---

Task 4: Thread ctx Through applyPatchToRepo and transferPR

Priority: Medium
Estimated Effort: Medium
Focus Area: Context Propagation

Description: applyPatchToRepo (line 257) has 20 bare exec.Command calls; its caller transferPR (line 536) also lacks ctx. The cobra RunE handler provides cmd.Context().

Acceptance Criteria:

• applyPatchToRepo gains ctx context.Context first parameter; 20 bare calls → exec.CommandContext(ctx, ...)
• transferPR gains ctx context.Context; passes to applyPatchToRepo
• NewPRTransferSubcommand RunE passes cmd.Context() to transferPR
• make lint and make test pass

Code Region: pkg/cli/pr_command.go:257,536

---

📊 Historical Context

Previous Focus Areas (last 5)

Date	Focus Area	Type	Custom	Key Outcomes
2026-06-19	Compilation Idempotence Gaps	Custom	Y	OrderMapFields shallow; unordered maps in ToMap()
2026-06-18	Race Detector Gap	Custom	Y	Zero -race in CI; 115 t.Parallel() unprotected
2026-06-17	Engine Catalog Adoption Gap	Custom	Y	AgenticEngines deprecated; EngineDefinition missing experimental field
2026-06-15	Documentation	Standard	N	75% packages lack doc.go
2026-06-12	Cobra Example Field Migration	Custom	Y	0/40+ commands use Example: field

---

🎯 Recommendations

Immediate Actions (This Week)

1. Fix remote_fetch.go:628 linter violation — Priority: High (one-line change)

Short-term Actions (This Month)

1. Thread ctx through pkg/cli/git.go utility functions — Priority: High
2. Thread ctx through copyTrialResultsToHostRepo — Priority: Medium

Long-term Actions (This Quarter)

1. Thread ctx through applyPatchToRepo / transferPR — Priority: Medium

---

📈 Success Metrics

• exec.CommandContext adoption: 23.9% → 50%+
• Linter violations in ctx-receiving functions: 1 → 0
• pkg/cli/git.go functions with ctx: 0/8 → 8/8

---

Next Steps

1. Review and prioritise the tasks above
2. Assign to Copilot coding agent via planner agent
3. Re-evaluate in 2 weeks

---

References:

• §27961043794

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by ⚡ Repository Quality Improvement Agent · 86 AIC · ⌖ 9.46 AIC · ⊞ 6.6K · ◷

• expires on Jun 23, 2026, 6:52 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-06-23T14:52:49.737Z.

Closed by Workflow