[Schema Consistency] 🔍 Schema Consistency Check - 2026-06-23 #40981
Closed
Replies: 1 comment
-
|
This discussion was automatically closed because it expired on 2026-06-24T06:39:25.927Z.
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
Critical Issues
engine.extensionsis implemented but missing from schema and docspkg/workflow/engine.go:514-534readsengineObj["extensions"]intoEngineConfig.Extensions.pkg/workflow/pi_engine.go:198,225emitspi install <extension>steps fromengine.extensions.pkg/parser/schemas/main_workflow_schema.json$defs.engine_configobject branch (11713-11958) setsadditionalProperties: falseand has noextensionsproperty.docs/src/content/docs/reference/frontmatter.md:145-150only documentsengine: copilot;docs/src/content/docs/reference/frontmatter-full.md:2098-2155lists engine object keys and also omitsextensions.engine.idis described as a fixed built-in set, but schema does not enforce it while runtime does$defs.engine_config.properties.idis onlytype: stringatpkg/parser/schemas/main_workflow_schema.json:11714-11717.claude,codex,copilot,gemini,opencode,crush,pi.pkg/workflow/engine_definition.go:268-276errors withinvalid engine: ... Valid engines are: ...for unknown IDs.Parser accepts
safe-outputs.dispatch-repository, but schema/docs only allowdispatch_repositorypkg/workflow/dispatch_repository.go:30-39explicitly accepts both underscore and dash spellings.pkg/parser/schemas/main_workflow_schema.json:9142+defines onlydispatch_repository.docs/src/content/docs/reference/frontmatter-full.md:7508documents onlydispatch_repository:.Documentation Gaps
frontmatter.mdis too high-level forengine:and does not mention advanced object-only keys such as the implemented Pi-specificextensionsfield.frontmatter-full.mdmirrors the schema omission, so users cannot discoverengine.extensionseven though the compiler supports it.dispatch_repositorydocs omit the accepted alias, so readers cannot predict which spellings validate versus merely parse.Schema Improvements Needed
engine.extensionsto$defs.engine_config.propertieswithtype: array,items: {"type":"string"}and a Pi-engine-specific description.engine.id/ runtime IDs with an enum or aoneOfsplit between built-in IDs and named catalog references, or clearly document why arbitrary strings are intentionally allowed.dispatch-repositoryshould be:Parser Updates Required
pkg/workflow/dispatch_repository.goor warn when used.engine.idvalues earlier so schema and compiler fail at the same layer.Workflow Violations
.github/workflows/*.mdduring this run.engine.extensions,dispatch-repository) that fail schema-based tooling or docs-driven linting.Recommendations
engine.extensionsto schema and both frontmatter references.engine.idso schema catches invalid built-in engine names earlier.dispatch_repositorynaming by either documenting/schema-allowing the dash alias or removing parser support.$defs.engine_config.Strategy Performance
Next Steps
engine.extensionsdispatch_repositoryalias handlingReferences:
Beta Was this translation helpful? Give feedback.
All reactions