Description
Two logger-instantiation hygiene gaps make the full set of logger namespaces statically unknowable:
- Three
logger.New(...) calls live inside the closeEntityRegistry slice literal in pkg/workflow/close_entity_helpers.go (lines ~172, 185, 198) — they are not reachable by grep -rn 'var.*Log.*= logger.New' audits.
newValidationLogger in pkg/workflow/validation_helpers.go:48 builds namespace strings via runtime concatenation; all 10 call sites pass string literals, so the names could be inlined.
Lift the three inline calls to greppable package-level vars, and inline the 10 literal-arg newValidationLogger call sites so every logger namespace is statically discoverable.
Expected Impact
Makes the complete namespace set greppable/auditable, supporting future collision detection (see companion cli:update_check fix). Mechanical, no behavior change.
Suggested Agent
Discussion Task Miner / Code Quality Improvement Agent.
Estimated Effort
Quick (< 1 hour)
Data Source
DeepReport analysis 2026-07-14; source report [repository-quality] #45489.
Generated by 🔬 Deep Report · 260.7 AIC · ⌖ 17.6 AIC · ⊞ 10K · ◷
Description
Two logger-instantiation hygiene gaps make the full set of logger namespaces statically unknowable:
logger.New(...)calls live inside thecloseEntityRegistryslice literal inpkg/workflow/close_entity_helpers.go(lines ~172, 185, 198) — they are not reachable bygrep -rn 'var.*Log.*= logger.New'audits.newValidationLoggerinpkg/workflow/validation_helpers.go:48builds namespace strings via runtime concatenation; all 10 call sites pass string literals, so the names could be inlined.Lift the three inline calls to greppable package-level vars, and inline the 10 literal-arg
newValidationLoggercall sites so every logger namespace is statically discoverable.Expected Impact
Makes the complete namespace set greppable/auditable, supporting future collision detection (see companion cli:update_check fix). Mechanical, no behavior change.
Suggested Agent
Discussion Task Miner / Code Quality Improvement Agent.
Estimated Effort
Quick (< 1 hour)
Data Source
DeepReport analysis 2026-07-14; source report [repository-quality] #45489.