Description
The Repository Quality Improvement Report (2026-08-24) flagged pkg/workflow/awf_config.go at 1,090 lines (verified via wc -l) as mixing three separable concerns across its 19 top-level functions: schema validation (validateAWFConfigJSON), config construction (BuildAWFConfigJSON), and policy/domain resolution (resolveModelPolicyForAWFConfig, intersectModelPolicyRules). This is the repo's 2nd-largest non-test Go file and, like the handler registry (see companion issue), was actively edited on the same day it was flagged — decomposition debt accumulating in high-churn code.
Split along the three natural seams (schema validation / config building / policy resolution) into separate files, consistent with the "one file per functionality" pattern used elsewhere in pkg/workflow.
Expected Impact
Improves reviewability and reduces merge-conflict surface for a file under active development; makes the three concerns independently testable/navigable.
Suggested Agent
New Agent / general coding agent — mechanical extraction along the documented function groupings, verify via existing config tests after the split.
Estimated Effort
Medium (1-4 hours).
Data Source
DeepReport Intelligence Briefing analysis, 2026-08-24 cycle, mining Repository Quality Improvement Report #55409. File size independently reverified via wc -l before filing.
Generated by 🔬 Deep Report · claude · agent · 267.3 AIC · ⌖ 9.56 AIC · ⊞ 12.4K · ◷
Description
The Repository Quality Improvement Report (2026-08-24) flagged
pkg/workflow/awf_config.goat 1,090 lines (verified viawc -l) as mixing three separable concerns across its 19 top-level functions: schema validation (validateAWFConfigJSON), config construction (BuildAWFConfigJSON), and policy/domain resolution (resolveModelPolicyForAWFConfig,intersectModelPolicyRules). This is the repo's 2nd-largest non-test Go file and, like the handler registry (see companion issue), was actively edited on the same day it was flagged — decomposition debt accumulating in high-churn code.Split along the three natural seams (schema validation / config building / policy resolution) into separate files, consistent with the "one file per functionality" pattern used elsewhere in
pkg/workflow.Expected Impact
Improves reviewability and reduces merge-conflict surface for a file under active development; makes the three concerns independently testable/navigable.
Suggested Agent
New Agent / general coding agent — mechanical extraction along the documented function groupings, verify via existing config tests after the split.
Estimated Effort
Medium (1-4 hours).
Data Source
DeepReport Intelligence Briefing analysis, 2026-08-24 cycle, mining Repository Quality Improvement Report #55409. File size independently reverified via
wc -lbefore filing.