Skip to content

Commit 735a482

Browse files
Copilotpelikhan
andauthored
Fix generic agent adapter typing
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent e26ce64 commit 735a482

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

skills/rig/rig.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ export function copilotEngine(options: CopilotEngineOptions = {}): AgentFactory
239239
return {
240240
async ask(prompt, askOptions = {}) {
241241
writeEvent(rigEvent("agent.ask", { prompt }));
242-
const response = await session.sendAndWait(
242+
const response = await (session.sendAndWait as any)(
243243
askOptions.signal ? { prompt, signal: askOptions.signal } : { prompt },
244244
);
245245
return responseText(response);
@@ -309,11 +309,11 @@ export type AgentAddon = (
309309
next: () => Promise<void>,
310310
) => void | Promise<void>;
311311
export type ToolHandler<TArgs = unknown> = (args: TArgs) => unknown | Promise<unknown>;
312-
export type ToolParameters<TArgs = unknown> = Schema | Record<string, unknown>;
312+
export type ToolParameters = Schema | Record<string, unknown>;
313313
export type Tool<TArgs = unknown> = ToolConfig<TArgs> & { name: string };
314314
export type ToolConfig<TArgs = unknown> = {
315315
description?: string;
316-
parameters?: ToolParameters<TArgs>;
316+
parameters?: ToolParameters;
317317
handler?: ToolHandler<TArgs>;
318318
overridesBuiltInTool?: boolean;
319319
skipPermission?: boolean;
@@ -1022,7 +1022,7 @@ function normalizeSpec(specOrName: AgentSpec<any, any>): NormalizedAgentSpec<any
10221022
return spec;
10231023
}
10241024

1025-
function normalizeToolParameters<T>(parameters: ToolParameters<T> | undefined): ToolParameters<T> | undefined {
1025+
function normalizeToolParameters(parameters: ToolParameters | undefined): ToolParameters | undefined {
10261026
return parameters !== undefined && isSchema(parameters) ? toJsonSchema(parameters) : parameters;
10271027
}
10281028

src/engines/copilot.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,11 @@ it("uses a URI (HTTP) connection by default", async () => {
4141

4242
expect(mocks.forUri).toHaveBeenCalledWith("localhost:7777");
4343
expect(mocks.copilotClientCtor).toHaveBeenCalledWith({ connection: { kind: "uri", url: "localhost:7777" } });
44-
expect(mocks.createSession).toHaveBeenCalledWith({ model: "gpt-5", streaming: false });
44+
expect(mocks.createSession).toHaveBeenCalledWith({
45+
model: "gpt-5",
46+
streaming: false,
47+
onPermissionRequest: mocks.approveAll,
48+
});
4549
});
4650

4751
it("uses COPILOT_SDK_URI when set", async () => {

0 commit comments

Comments
 (0)