Skip to content

Clarify repair and steering addon usage - #90

Merged
pelikhan merged 4 commits into
mainfrom
copilot/rig-tasks-daily-evaluation-2026-07-24-yet-again
Jul 24, 2026
Merged

Clarify repair and steering addon usage#90
pelikhan merged 4 commits into
mainfrom
copilot/rig-tasks-daily-evaluation-2026-07-24-yet-again

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Daily Rig evaluation exposed recurring misuse of repair, steering, and unused defineTool parameters. Existing guidance also reversed the middleware order required for steering to observe repair prompts.

  • Addon guidance

    • Document repair as a bare addon with maxTurns configured on the agent.
    • Correct ordering to [steering(), repair].
    • Document custom warnings via steering({ message }).
    • Add API JSDoc for IDE discoverability.
  • Strict TypeScript handlers

    • Recommend destructuring only used tool arguments or aliasing unavoidable bindings with an underscore.
const check = agent({
  maxTurns: 3,
  addons: [
    steering({ message: "Return valid JSON now." }),
    repair,
  ],
});

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors in daily rig evaluation tasks Clarify repair and steering addon usage Jul 24, 2026
Copilot AI requested a review from pelikhan July 24, 2026 05:51
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot make repair a function as well (that takes { maxTurns:... }) as options so that it matches steering and is less confusing.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot make repair a function as well (that takes { maxTurns:... }) as options so that it matches steering and is less confusing.

Implemented in 0d63766. repair is now an options-based factory (repair({ maxTurns })), with callers, tests, samples, and guidance updated.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot keep maxTurns as an agent level option, remove option maxTurns from "repair" options.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot keep maxTurns as an agent level option, remove option maxTurns from "repair" options.

Implemented in ed0541c. repair() is now zero-argument, and maxTurns remains on the agent spec (with the existing call-time override). The addon-level option and budget metadata were removed, and callers/docs were updated.

@pelikhan
pelikhan marked this pull request as ready for review July 24, 2026 06:36
@pelikhan
pelikhan merged commit a032d6c into main Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rig-tasks] Daily rig evaluation — 2026-07-24 — 5/5 passed

2 participants