refactor: remove legacy account model and migration util (#1787)

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/__mocks__/state-mocks.ts

@@ -15,16 +15,8 @@ import {
   Theme,
   type Token,
 } from '../types';
-import type { EnterpriseAccount } from '../utils/auth/types';
 import { Constants } from '../utils/constants';
 
-export const mockEnterpriseAccounts: EnterpriseAccount[] = [
-  {
-    hostname: 'github.gitify.io' as Hostname,
-    token: '1234568790' as Token,
-  },
-];
-
 export const mockGitifyUser: GitifyUser = {
   login: 'octocat',
   name: 'Mona Lisa Octocat',

src/renderer/context/App.test.tsx

@@ -48,7 +48,7 @@ describe('renderer/context/App.tsx', () => {
     const unsubscribeNotificationMock = jest.fn();
 
     const mockDefaultState = {
-      auth: { accounts: [], enterpriseAccounts: [], token: null, user: null },
+      auth: { accounts: [] },
       settings: mockSettings,
     };
 
@@ -278,9 +278,6 @@ describe('renderer/context/App.tsx', () => {
       expect(saveStateMock).toHaveBeenCalledWith({
         auth: {
           accounts: [],
-          enterpriseAccounts: [],
-          token: null,
-          user: null,
         } as AuthState,
         settings: {
           ...defaultSettings,
@@ -319,9 +316,6 @@ describe('renderer/context/App.tsx', () => {
       expect(saveStateMock).toHaveBeenCalledWith({
         auth: {
           accounts: [],
-          enterpriseAccounts: [],
-          token: null,
-          user: null,
         } as AuthState,
         settings: {
           ...defaultSettings,
@@ -354,9 +348,6 @@ describe('renderer/context/App.tsx', () => {
       expect(saveStateMock).toHaveBeenCalledWith({
         auth: {
           accounts: [],
-          enterpriseAccounts: [],
-          token: null,
-          user: null,
         } as AuthState,
         settings: {
           ...mockSettings,
@@ -390,9 +381,6 @@ describe('renderer/context/App.tsx', () => {
       expect(saveStateMock).toHaveBeenCalledWith({
         auth: {
           accounts: [],
-          enterpriseAccounts: [],
-          token: null,
-          user: null,
         } as AuthState,
         settings: defaultSettings,
       });

src/renderer/context/App.tsx

@@ -31,7 +31,6 @@ import {
 } from '../types';
 import type { Notification } from '../typesGitHub';
 import { headNotifications } from '../utils/api/client';
-import { migrateAuthenticatedAccounts } from '../utils/auth/migration';
 import type {
   LoginOAuthAppOptions,
   LoginPersonalAccessTokenOptions,
@@ -63,9 +62,6 @@ import { zoomPercentageToLevel } from '../utils/zoom';
 
 export const defaultAuth: AuthState = {
   accounts: [],
-  token: null,
-  enterpriseAccounts: [],
-  user: null,
 };
 
 const defaultAppearanceSettings: AppearanceSettingsState = {
@@ -279,7 +275,6 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
   );
 
   const restoreSettings = useCallback(async () => {
-    await migrateAuthenticatedAccounts();
     const existing = loadState();
 
     // Restore settings before accounts to ensure filters are available before fetching notifications

src/renderer/types.ts

@@ -1,30 +1,14 @@
 import type { OcticonProps } from '@primer/octicons-react';
 import type { FC } from 'react';
 import type { Notification, Reason } from './typesGitHub';
-import type {
-  AuthMethod,
-  EnterpriseAccount,
-  PlatformType,
-} from './utils/auth/types';
+import type { AuthMethod, PlatformType } from './utils/auth/types';
 
 declare const __brand: unique symbol;
 
 type Brand<B> = { [__brand]: B };
 
 export interface AuthState {
   accounts: Account[];
-  /**
-   * @deprecated This attribute is deprecated and will be removed in a future release.
-   */
-  token?: Token;
-  /**
-   * @deprecated This attribute is deprecated and will be removed in a future release.
-   */
-  enterpriseAccounts?: EnterpriseAccount[];
-  /**
-   * @deprecated This attribute is deprecated and will be removed in a future release.
-   */
-  user?: GitifyUser | null;
 }
 
 export type Branded<T, B> = T & Brand<B>;

src/renderer/utils/auth/migration.test.ts

@@ -31,11 +31,3 @@ export interface AuthTokenResponse {
   hostname: Hostname;
   token: Token;
 }
-
-/**
- * @deprecated This type is deprecated and will be removed in a future release.
- */
-export interface EnterpriseAccount {
-  hostname: Hostname;
-  token: Token;
-}