Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org.apache.logging.log4j dependencies #2

Open
arichiardi opened this issue Sep 27, 2016 · 0 comments · May be fixed by #3
Open

Remove org.apache.logging.log4j dependencies #2

arichiardi opened this issue Sep 27, 2016 · 0 comments · May be fixed by #3

Comments

@arichiardi
Copy link

arichiardi commented Sep 27, 2016

From my (limited) experience 😄 with Java log, it looks like the org.apache.logging.log4j dependencies are only necessary at runtime.

It makes sense, the logger is a Java service and it is resolved at runtime, version and all. For instance in my project I have:

                [org.apache.logging.log4j/log4j-api "2.6.2" :scope "runtime"]
                [org.apache.logging.log4j/log4j-core "2.6.2" :scope "runtime"]
                [org.apache.logging.log4j/log4j-jcl "2.6.2" :scope "runtime"]
                [org.apache.logging.log4j/log4j-jul "2.6.2" :scope "runtime"]
                [org.apache.logging.log4j/log4j-1.2-api "2.6.2" :scope "runtime"]
                [org.apache.logging.log4j/log4j-slf4j-impl "2.6.2" :scope "runtime"]  

See the :scope? Everything is working fine. For this reason I would suggest to patch project.clj, remove the deps and let the app using your lib decide the implementation to hook.

arichiardi added a commit to arichiardi/clj-log4j2 that referenced this issue Sep 27, 2016
@arichiardi arichiardi linked a pull request Sep 27, 2016 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant