Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let RadialWindow compute its effective redshift if not given #495

Open
ntessore opened this issue Jan 31, 2025 · 0 comments
Open

Let RadialWindow compute its effective redshift if not given #495

ntessore opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ntessore
Copy link
Collaborator

Is Your Feature Request Related to a Problem? Please Describe

I'm always frustrated when I have to manually compute RadialWindow.zeff even though I am passing the redshift distribution.

Describe the Solution You'd Like

I would like the default zeff to be None, in which case RadialWindow computes the mean redshift as

zeff = np.trapezoid(za * wa, za) / np.trapezoid(wa, za) if za.size > 0 else 0.0

Describe Alternatives You've Considered

No response

Additional Context

No response
@ntessore ntessore added the enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntessore