Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Reopens After Instantiation #57

Open
chadhietala opened this issue Jan 31, 2016 · 1 comment
Open

Deprecate Reopens After Instantiation #57

chadhietala opened this issue Jan 31, 2016 · 1 comment

Comments

@chadhietala
Copy link
Member

I've mentioned this before in emberjs/ember.js#12200, seems like we may want to do this in the new object system. While I understand that it may hinder addons, it will be more of a foot gun when async engines are a thing and you lazy load some code that potentially modifies the prototype of all the classes already held in memory.

Don't want to get into scope creep, but I think this needs to be done regardless of new object system.

@sandstrom
Copy link

I'm doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it's quite old I just wanted to ask if this is still relevant? If it isn't, maybe we can close this issue?

Since classes (modern JS) are no longer reopenable, maybe this isn't an issue anymore?

By closing some old issues we reduce the list of open issues to a more manageable set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants