Revert "fix(itil): Move back readonly logic in the object with API having passing throug"

This reverts commit ac14bf1.

Author: froozeify

front/change.form.php

@@ -53,6 +53,7 @@
 if (isset($_POST["add"])) {
     $change->check(-1, CREATE, $_POST);
 
+    $_POST = $change->enforceReadonlyFields($_POST, true);
     $newID = $change->add($_POST);
     Event::log(
         $newID,
@@ -109,6 +110,7 @@
 } elseif (isset($_POST["update"])) {
     $change->check($_POST["id"], UPDATE);
 
+    $_POST = $change->enforceReadonlyFields($_POST);
     $change->update($_POST);
     Event::log(
         $_POST["id"],

front/problem.form.php

@@ -53,6 +53,7 @@
 if (isset($_POST["add"])) {
     $problem->check(-1, CREATE, $_POST);
 
+    $_POST = $problem->enforceReadonlyFields($_POST, true);
     if ($newID = $problem->add($_POST)) {
         Event::log(
             $newID,
@@ -108,6 +109,7 @@
 } elseif (isset($_POST["update"])) {
     $problem->check($_POST["id"], UPDATE);
 
+    $_POST = $problem->enforceReadonlyFields($_POST);
     $problem->update($_POST);
     Event::log(
         $_POST["id"],

front/ticket.form.php

@@ -74,6 +74,7 @@
 
 if (isset($_POST["add"])) {
     $track->check(-1, CREATE, $_POST);
+    $_POST = $track->enforceReadonlyFields($_POST, true);
 
     if ($track->add($_POST)) {
         if ($_SESSION['glpibackcreated']) {
@@ -85,6 +86,7 @@
     if (!$track::canUpdate()) {
         throw new AccessDeniedHttpException();
     }
+    $_POST = $track->enforceReadonlyFields($_POST);
     $track->update($_POST);
 
     if (isset($_POST['kb_linked_id'])) {

src/CommonITILObject.php

@@ -1967,8 +1967,6 @@ public function prepareInputForUpdate($input)
             return false;
         }
 
-        $input = $this->enforceReadonlyFields($input);
-
         // Add document if needed
         $this->getFromDB($input["id"]); // entities_id field required
 
@@ -2345,11 +2343,6 @@ public function prepareInputForUpdate($input)
      */
     public function enforceReadonlyFields(array $input, bool $isAdd = false): array
     {
-        // No enforcing for API
-        if (isAPI() || isCommandLine()) {
-            return $input;
-        }
-
         $tt = $this->getITILTemplateFromInput($input);
         if (!$tt) {
             return $input;
@@ -2845,8 +2838,6 @@ public function prepareInputForAdd($input)
             return false;
         }
 
-        $input = $this->enforceReadonlyFields($input, true);
-
         $input = $this->transformActorsInput($input);
 
         // Map unique template field to template foreign key