Skip to content

Commit 5a15bd6

Browse files
committed
fix: PHP lint
1 parent 8affe98 commit 5a15bd6

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/Glpi/Form/Migration/FormMigration.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ private function processMigrationOfQuestions(): void
477477
$question->getID()
478478
);
479479
} catch (\Throwable $th) {
480-
$section = Section::getById($section_id);
480+
$section = Section::getById($section_id) ?: null;
481481
$this->result->addMessage(
482482
MessageType::Error,
483483
sprintf(

src/Glpi/Form/QuestionType/AbstractQuestionTypeSelectable.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public function convertDefaultValue(array $rawData): array
195195
$default_values = json_decode($rawData['default_values']);
196196
if (
197197
($default_values === null && json_last_error() !== JSON_ERROR_NONE)
198-
|| !empty($rawData['default_values']) && !is_array($default_values)
198+
|| !is_array($default_values)
199199
) {
200200
$default_values = [$rawData['default_values']];
201201
}

src/Glpi/Form/QuestionType/QuestionTypeUrgency.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,11 @@ public function getConditionHandler(
195195
#[Override]
196196
public function convertDefaultValue(array $rawData): ?int
197197
{
198-
return (int) $rawData['default_values'] ?? null;
198+
if (!isset($rawData['default_values'])) {
199+
return null;
200+
}
201+
202+
return (int) $rawData['default_values'];
199203
}
200204

201205
#[Override]

0 commit comments

Comments
 (0)