Fix form export with entity question special default value

Author: AdrienClairembault

src/Glpi/Form/QuestionType/QuestionTypeItem.php

@@ -675,7 +675,7 @@ public function exportDynamicExtraData(
         // Stop here if value is invalid or empty
         $itemtype = $extra_data_config[QuestionTypeItemExtraDataConfig::ITEMTYPE] ?? "";
         $root_id = $extra_data_config[QuestionTypeItemDropdownExtraDataConfig::ROOT_ITEMS_ID] ?? 0;
-        if ($root_id == 0 || !is_a($itemtype, CommonDBTM::class, true)) {
+        if ($root_id <= 0 || !is_a($itemtype, CommonDBTM::class, true)) {
             return $fallback;
         }
 
@@ -708,6 +708,9 @@ public static function prepareDynamicExtraDataForImport(
         if (
             !(getItemForItemtype($itemtype) instanceof CommonDBTM)
             || empty($name)
+            // Both these values represent the root entity, no need to map it
+            || $name == 0
+            || $name == -1
         ) {
             return $fallback;
         }

tests/functional/Glpi/Form/Export/FormSerializerTest.php

@@ -90,6 +90,8 @@
 use Ramsey\Uuid\Uuid;
 use Session;
 
+use function Safe\json_encode;
+
 final class FormSerializerTest extends \DbTestCase
 {
     use FormTesterTrait;
@@ -1682,6 +1684,25 @@ public function testTagsAreUpdatedWhenImporting(): void
         );
     }
 
+    public function testWithFormWithSpecialNegativeIdForRootEntity(): void
+    {
+        // Arrange: create a form with a -1 value for root_items_id
+        $builder = new FormBuilder("My form");
+        $extra_data = new QuestionTypeItemExtraDataConfig(
+            itemtype: Entity::class,
+            root_items_id: -1,
+        );
+        $builder->addQuestion(
+            name: "Entity",
+            type: QuestionTypeItem::class,
+            extra_data: json_encode($extra_data)
+        );
+        $form = $this->createForm($builder);
+
+        // Act: export the form, no error should happen
+        $this->exportAndImportForm($form);
+    }
+
     private function compareValuesForRelations(
         $relations,
         $ids_for_default_form,