Add test on mail collector rules with known domain (#21563)

* Add test on mail collector rules with known domain

Possibly fix an issue
closes #21561

* CS

Author: trasher

src/RuleMailCollectorCollection.php

@@ -57,6 +57,9 @@ public function prepareInputDataForProcess($input, $params)
         if (isset($params['_users_id_requester'])) {
             $input['_users_id_requester'] = $params['_users_id_requester'];
         }
+        if (isset($params['from'])) {
+            $input['from'] = $params['from'];
+        }
 
         $fields = $this->getFieldsToLookFor();
 
@@ -125,7 +128,6 @@ public function prepareInputDataForProcess($input, $params)
             }
         }
 
-        // Store the number of profiles of which the user belongs to
         if (in_array('known_domain', $fields, true)) {
             if (preg_match("/@(.*)/", $input['from'], $results)) {
                 if (Entity::getEntityIDByDomain($results[1]) !== -1) {

tests/functional/RuleMailCollectorTest.php

@@ -140,6 +140,97 @@ public function testAssignEntityBasedOnGroup()
         );
     }
 
+    public function testAssignEntityBasedOnKnowDomain()
+    {
+        $this->login();
+
+        $entity         = getItemByTypeName('Entity', '_test_child_1');
+        $entity_id      = $entity->getID();
+        $this->assertTrue(
+            $entity->update([
+                'id'          => $entity_id,
+                'mail_domain' => 'glpi-project.org',
+            ])
+        );
+        $entity->getFromDB($entity_id);
+        $this->assertSame('glpi-project.org', $entity->getField('mail_domain'));
+        $normal_user_id = getItemByTypeName('User', 'normal', true);
+
+        // Delete all existing rule
+        $rule     = new Rule();
+        $rule->deleteByCriteria(['sub_type' => 'RuleMailCollector']);
+
+        // Create rule
+        $rule     = new \RuleMailCollector();
+        $rule_id = $rule->add($rule_input = [
+            'name'         => 'test assign entity based on known domain',
+            'match'        => 'AND',
+            'is_active'    => 1,
+            'sub_type'     => 'RuleMailCollector',
+        ]);
+        $this->checkInput($rule, $rule_id, $rule_input);
+
+        // Create criteria to check if requester group matches a specific group
+        $criteria = new RuleCriteria();
+        $criteria_id = $criteria->add($criteria_input = [
+            'rules_id'  => $rule_id,
+            'criteria'  => 'KNOWN_DOMAIN',
+            'condition' => Rule::PATTERN_IS,
+            'pattern'   => 1,
+        ]);
+        $this->checkInput($criteria, $criteria_id, $criteria_input);
+
+        // Create action to assign entity
+        $action   = new RuleAction();
+        $action_id = $action->add($action_input = [
+            'rules_id'    => $rule_id,
+            'action_type' => 'assign',
+            'field'       => 'entities_id',
+            'value'       => $entity_id,
+        ]);
+        $this->checkInput($action, $action_id, $action_input);
+
+        // Check rules output: no rule should match
+        $rulecollection = new RuleMailCollectorCollection();
+        $output         = $rulecollection->processAllRules(
+            [],
+            [],
+            [
+                'mailcollector'       => 0,
+                '_users_id_requester' => $normal_user_id,
+                'from'                => '[email protected]',
+            ]
+        );
+
+        $this->assertEquals(
+            [
+                '_no_rule_matches' => '1',
+                '_rule_process'    => '',
+            ],
+            $output
+        );
+
+        // Check rules output: new rule should match
+        $rulecollection = new RuleMailCollectorCollection();
+        $output         = $rulecollection->processAllRules(
+            [],
+            [],
+            [
+                'mailcollector'       => 0,
+                '_users_id_requester' => $normal_user_id,
+                'from'                => '[email protected]',
+            ]
+        );
+
+        $this->assertEquals(
+            [
+                'entities_id' => $entity_id,
+                '_ruleid'     => $rule_id,
+            ],
+            $output
+        );
+    }
+
     public function testExternalID()
     {
         $entity_id      = getItemByTypeName('Entity', '_test_child_1', true);