fix: PHPUnit test

Author: ccailly

phpunit/functional/Glpi/Form/AnswersSetTest.php

@@ -40,6 +40,7 @@
 use Glpi\Form\Answer;
 use Glpi\Form\AnswersHandler\AnswersHandler;
 use Glpi\Form\AnswersSet;
+use Glpi\Form\DelegationData;
 use Glpi\Form\Destination\FormDestinationProblem;
 use Glpi\Form\Form;
 use Glpi\Form\Question;
@@ -150,11 +151,11 @@ public function testGetDelegationWihoutRights()
             [],
             \Session::getLoginUserID(),
             [],
-            [
-                'users_id'          => getitemByTypeName(User::class, 'glpi')->getID(),
-                'use_notification'  => true,
-                'alternative_email' => ''
-            ]
+            new DelegationData(
+                getitemByTypeName(User::class, 'glpi')->getID(),
+                true,
+                ''
+            )
         );
 
         /** @var Ticket $ticket */
@@ -217,11 +218,11 @@ public function testGetDelegation()
             [],
             \Session::getLoginUserID(),
             [],
-            [
-                'users_id'          => getitemByTypeName(User::class, 'glpi')->getID(),
-                'use_notification'  => true,
-                'alternative_email' => ''
-            ]
+            new DelegationData(
+                getitemByTypeName(User::class, 'glpi')->getID(),
+                true,
+                ''
+            ),
         );
 
         /** @var Ticket $ticket */

src/Glpi/Controller/Form/SubmitAnswerController.php

@@ -113,8 +113,8 @@ private function saveSubmittedAnswers(
             $form,
             $answers,
             Session::getLoginUserID(),
-            $delegation,
-            $files
+            $files,
+            $delegation
         );
 
         return $answers;

src/Glpi/Form/AnswersHandler/AnswersHandler.php

@@ -93,8 +93,8 @@ public function saveAnswers(
         Form $form,
         array $answers,
         int $users_id,
-        DelegationData $delegation,
         array $files = [],
+        DelegationData $delegation = new DelegationData(),
     ): AnswersSet {
         /** @var \DBmysql $DB */
         global $DB;

src/Glpi/Form/DelegationData.php

@@ -37,9 +37,9 @@
 final class DelegationData
 {
     public function __construct(
-        public readonly ?int $users_id,
-        public readonly ?bool $use_notification,
-        public readonly ?string $alternative_email
+        public readonly ?int $users_id = null,
+        public readonly ?bool $use_notification = null,
+        public readonly ?string $alternative_email = null
     ) {
     }
 }