We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we already have an identifier for a job.
gocron/job.go
Line 754 in 63f3701
why do we need another one in the locker ? Why don't we just pass that as a parameter ?
gocron/executor.go
Line 387 in 63f3701
https://github.com/go-co-op/gocron-gorm-lock/blob/c615ac7060c9c09324ea80ed6a68d8c1769e2991/gorm_lock.go#L67
func (g *GormLocker) Lock(ctx context.Context, key string) (gocron.Lock, error) { ji := g.jobIdentifier(ctx, key) // <- here cjb := &CronJobLock{ JobName: key, JobIdentifier: ji, Worker: g.worker, Status: StatusRunning, } tx := g.db.WithContext(ctx).Create(cjb) if tx.Error != nil { return nil, tx.Error } return &gormLock{db: g.db, id: cjb.GetID()}, nil }
The text was updated successfully, but these errors were encountered:
No branches or pull requests
we already have an identifier for a job.
gocron/job.go
Line 754 in 63f3701
why do we need another one in the locker ? Why don't we just pass that as a parameter ?
gocron/executor.go
Line 387 in 63f3701
https://github.com/go-co-op/gocron-gorm-lock/blob/c615ac7060c9c09324ea80ed6a68d8c1769e2991/gorm_lock.go#L67
The text was updated successfully, but these errors were encountered: