Huge pull request creation timeout #27967
Labels
Comments
|
You may need to adjust these timeouts: gitea/custom/conf/app.example.ini Lines 700 to 707 in 69d98f8 |
I don't see timeout for |
|
|
Seems like it doesn't work, process fails on reverse proxy timeout in 10 minutes, not in 6 minutes with default value. |
|
Hi, we are observing a similar behavior: In our case it's not, that the pull request itself is that big. But the amount of files identified by following Function ist ~ 1000. gitea/services/pull/patch_unmerged.go Line 57 in 709a376 Because of this the following loop runs several minutes, resulting in a timeout because of our Reverse-Proxy (which was set to gitea/services/pull/patch_unmerged.go Line 161 in 709a376 We set the reverse-proxy timeout to 6 Minutes, to match the gitea default timeout values. As a workaround this "resolved" the Gitea Version Git Version Operating System How are you running Gitea? PowerEdge R630: CPU: 2 * Intel Xeon E5-2630 v3 (2.4GHz; 8 Cores), Storage: SAS, Memory: 128GB Database |
Closed
|
As a workaround you can create PR based on branch equals to base branch, and then push new commits into it. |
|
We're also running into this issue, unfortunately. Even with: |
|
It appears that running I have a change here that helps for file removal, but not file addition yet. I won't have time to finish this, but maybe someone else will pick it up. |
brechtvl
added a commit
to brechtvl/gitea
that referenced
this issue
Jul 3, 2024
Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking takes about a second. Related to go-gitea#27967, though this will not help with commits that change many lines in few files.
techknowlogick
pushed a commit
that referenced
this issue
Jul 4, 2024
…31548) Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to #27967, though this will not help with commits that change many lines in few files.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Jul 4, 2024
…o-gitea#31548) Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files.
silverwind
pushed a commit
that referenced
this issue
Jul 5, 2024
…31548) (#31560) Backport #31548 by @brechtvl Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to #27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to blender/gitea
that referenced
this issue
Jul 15, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
bartvdbraak
pushed a commit
to bartvdbraak/gitea
that referenced
this issue
Nov 21, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Nov 22, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Nov 22, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Nov 28, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Dec 4, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Dec 4, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
blender-it
pushed a commit
to blender/gitea
that referenced
this issue
Dec 4, 2024
… files Running git update-index for every individual file is slow, so add and remove everything with a single git command. When such a big commit lands in the default branch, it could cause PR creation and patch checking for all open PRs to be slow, or time out entirely. For example, a commit that removes 1383 files was measured to take more than 60 seconds and timed out. With this change checking took about a second. This is related to go-gitea#27967, though this will not help with commits that change many lines in few files. Co-authored-by: Brecht Van Lommel <[email protected]>
|
Duplicate of #31600 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I have huge pull request with more that 1kk diff lines and it always fails with timeout.
I raised the timeout on the reverse proxy side to 5 minutes, and then to 10 minutes, but this did not help. I don’t know if there is any point in raising the timeout anymore.
Here is some errors from logs:
I tried to add more RAM and CPU to VM, but it doesn't help. Judging by htop, this operation does not waste a lot of resources.
Gitea Version
1.20.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
Git Version
2.30.2
Operating System
Debian 11
How are you running Gitea?
Selfhosted with systemd unit, downloaded from releases page on github.
VM instance has 8GB of RAM and 4 vCPU.
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: