Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose dataframe.print() method to users #127

Open
d3an opened this issue Aug 23, 2020 · 2 comments
Open

Expose dataframe.print() method to users #127

d3an opened this issue Aug 23, 2020 · 2 comments

Comments

@d3an
Copy link

d3an commented Aug 23, 2020

Right now, dataframe.print() is a private method only used by dataframe.String(). Can we expose this method to users, so that they can print a full dataframe if they'd like, instead of just a shortened preview?

Basically, just change dataframe.print() to be dataframe.Print().

@streamdp
Copy link

streamdp commented Nov 9, 2021

I also think about it, but it seems to me more correct to make parameters in dataframe.String(). Something like:

func (df DataFrame) String(args ...interface{}) (str string) {
}

or

type Parameters struct {
  ShortRow bool
  ShortCol bool 
  ...
}
func (df DataFrame) String(prm Parameters) (str string) {
}

What do you think about this?

@jordanh
Copy link

jordanh commented Jan 31, 2024

I also think about it, but it seems to me more correct to make parameters in dataframe.String(). Something like...

+1 to this, if there is support I'd be happy to fork and make this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants