-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How much work needed to support time types #93
Comments
Hello, Hope you still interested on this issue. I've been working lately on processing files with different formats and handling time is very difficult. As the README.md says: I've been using this library for parsing date fields. But I was working with predefined schemas. Hope my experience working with dates helps on this issue. |
I second that support for time.Time is highly relevant; I expect supporting just time.Time and not arbitrary strings removes the complexity @dgrr mentions. |
For me an acceptable first step for supporting time would be to just parse time strings as string and allowing the user to cast the column to a time series. |
After loading a slice of structs with
dataframe.LoadStructs(myStruct)
and printing the dataframe I found this message:DataFrame error: type (time.Time) is not supported
I checked the code base - but I am still new to it, and I found evidence of that message in here: https://github.com/go-gota/gota/blob/master/dataframe/dataframe.go
dataframe.LoadStructs(myStruct)
?I am wondering if there is a reason why time-related types were not included in the allowed types?
I am basically trying to reproduce what Pandas does (a well established Python package) like:
I don't have the need of grouping by time at the moment.
Anyway I am not sure how much work would this kind of features require as I think this type has been kept out because of these potential implications (and work to do to allow this functionality).
This seems related to this:
#20
#71
The text was updated successfully, but these errors were encountered: