Skip to content

Fix error when returning error for getConfiguration #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajwild opened this issue Oct 28, 2016 · 0 comments
Open

Fix error when returning error for getConfiguration #131

ajwild opened this issue Oct 28, 2016 · 0 comments
Labels

Comments

@ajwild
Copy link
Member

ajwild commented Oct 28, 2016

The following code from the getConfiguration function throws an error because app does not exist:

error = {
  "error": "The configuration could not be obtained.",
  "log": app.error || ""
};

Personally I don't think it's an error if the configuration doesn't exist, the function should just return undefined. However, I didn't want to change anything because there may be some apps waiting for the error message.

@ajwild ajwild added the bug label Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant