Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniswap plugin has ambiguous parameters #341

Open
nabeelraza-7 opened this issue Feb 14, 2025 · 0 comments
Open

Uniswap plugin has ambiguous parameters #341

nabeelraza-7 opened this issue Feb 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@nabeelraza-7
Copy link

Describe the bug
When using the uniswap plugin, the parameters tokenIn and tokenOut are assumed to be strings but the API request requires them to be addresses

To Reproduce
Sample parameters:

{
  tokenIn: 'WETH',
  tokenOut: 'WBTC',
  amount: '1',
  type: 'EXACT_INPUT',
  protocols: [ 'V2', 'V3' ],
  routingPreference: 'CLASSIC'
}

Error:

{
  "errorCode": "RequestValidationError",
  "detail": "\"tokenIn\" with value \"WETH\" fails to match the required pattern: /^0x[a-fA-F0-9]{40}$/"
}

Expected behavior
There should be some preprocessing that converts this appropriately OR looks up their addresses

@nabeelraza-7 nabeelraza-7 added the bug Something isn't working label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant