Skip to content

Fix Travis-CI build & simplify Makefile & fix README #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Fix Travis-CI build & simplify Makefile & fix README #33

wants to merge 29 commits into from

Conversation

@hoijui
Copy link

@hoijui hoijui commented Apr 20, 2019

see commits for details

@petar
Copy link
Member

petar commented Apr 21, 2019

This looks good. Thank you. The only issue is that syscall.Dup3 does not compile on my machine:
go version go1.12.4 darwin/amd64

To solve this issue, could you add a separate sigpanic_save_panic_trace.go for darwin and linux, perhaps?

@hoijui
use syscall.Dup3 on "!windows,arm" and Dup2 on other archs [fix]
f3cf4e2 
On windows, we use totally different code,
not using any `syscall.Dup*` calls.
@hoijui
Copy link
Author

hoijui commented Apr 21, 2019

Did that (I think).

@hoijui
Copy link
Author

hoijui commented Apr 21, 2019 •
edited
Loading

ah.. I just saw that there are 4 arm archs:

  • arm
  • armbe
  • arm64
  • arm64be

reference

would I have to define all of them in the +build coment, or does arm stand for all of them?
@ericvh Can you please test if this code still compiles for you?

Edit: It shoul'd work for arm64 now too

@hoijui
Copy link
Author

hoijui commented May 17, 2019 •
edited
Loading

as it is now, syscall.Dup3 will only be used on ARM archs, so for you it will still use syscall.Dup2. The latest commit adds windows and OSX builds to Travis-CI, and they compile fine.

hoijui added 16 commits April 27, 2020 08:13
@hoijui
README: fix typo in link
fae3da1
@hoijui
change project URL from gocircuit to hoijui
3dd1296 
* github.com/gocircuit/circuit -> github.com/hoijui/circuit
@hoijui
update to new version of dependency "github.com/urfave/cli" [fix]
c33f807
@hoijui
convert into a go _module_ (and use modules (style) imports)
e3cf465
@hoijui
remove the Makefile (use go install -v ./cmd/circuit/ instead)
e8a7832
@hoijui
move packages from repo root to pkg
b8a4f78
@hoijui
add a TODO (make internal dependencies external)
4230f31
@hoijui
lots of fixes, found through unit tests [fix]
201074a
@hoijui
update git ignores
9fee2e2
@hoijui
CI: use GitHub actions instead of Travis-CI
4f32bd1
@hoijui
remove copied-in dependencies, and rely on the module systems deps
d63834d
@hoijui
CI: fix documentation glob
75d90c8
@hoijui
homepage: modernize bagdes
c1f43ff
@hoijui
CI: remove homepage/tutorial; it is part of the homepage, not a bin […
f68f3e7 
…fix]
@hoijui
homepage: add go.dev badge
c4557e4
@hoijui
apply "go fmt ./..."
cad06e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoijui @petar @ericvh