Skip to content

Commit 81115e0

Browse files
Fix busted container (#409)
* Fix busted container We were trying really hard to build with python 3.11 and getting a busted result. Force build with python 3.10 and everything is easy -- and the result works. * Revert "drop support for python36 (#400)" This reverts commit 70e4667. We need to defer this until after the 3.3.1 bugfix is released. * version bump Co-authored-by: Scott Bailey <[email protected]>
1 parent 70e4667 commit 81115e0

File tree

6 files changed

+132
-73
lines changed

6 files changed

+132
-73
lines changed

.github/workflows/ci.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os: [ubuntu-latest, windows-latest, macos-latest]
25-
python-version: [3.7, 3.8, 3.9, "3.10"]
25+
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"]
2626
include:
2727
- os: ubuntu-latest
2828
path: ~/.cache/pypoetry
@@ -39,6 +39,7 @@ jobs:
3939
name: Checkout the repo
4040
- uses: actions/cache@c64c572235d810460d0d6876e9c705ad5002b353
4141
name: Cache Poetry & Tox deps
42+
if: ${{ !(matrix.os == 'windows-latest' && matrix.python-version == '3.6') }}
4243
with:
4344
path: |
4445
{{ matrix.path }}

CHANGELOG.md

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
1+
v3.3.1 - 23 Nov 2022
2+
--------------------
3+
4+
Bug fixes:
5+
* [#408](https://github.com/godaddy/tartufo/issues/408) - 3.3.0 container broken
6+
* Rebuild container using python 3.10 base instead of python 3.11
7+
* Eliminates reference to missing library present in 3.3.0 container
8+
* Eliminates requirement for build-it-yerself libraries in container
9+
110
v3.3.0 - 22 Nov 2022
2-
----------------------
11+
--------------------
312
Features:
413
* [#401](https://github.com/godaddy/tartufo/pull/401) - Add report output format
514

Dockerfile

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3-slim as base
1+
FROM python:3.10-slim as base
22

33
WORKDIR /app
44

@@ -9,14 +9,6 @@ ENV PIP_DEFAULT_TIMEOUT=100 \
99
PIP_NO_CACHE_DIR=1 \
1010
POETRY_VERSION=1.1.12
1111

12-
RUN apt-get update && apt-get upgrade -y && apt-get install make cmake gcc libssl-dev wget -y
13-
RUN wget https://github.com/libgit2/libgit2/archive/refs/tags/v1.4.0.tar.gz -O libgit2-1.4.0.tar.gz \
14-
&& tar xzf libgit2-1.4.0.tar.gz \
15-
&& cd libgit2-1.4.0/ \
16-
&& cmake . \
17-
&& make \
18-
&& make install
19-
RUN apt-get install libffi-dev -y
2012
RUN pip --no-cache-dir install "poetry==$POETRY_VERSION"
2113
RUN python -m venv /venv
2214

0 commit comments

Comments
 (0)