toon shading issue

[nagasawamaki]

Godot version:
3.0.2

OS/device including version:
Windows 7, Nvidia GeForce GTX 1060

Issue description:
I am testing Godot toon shader for my character but I found some issues on it.

First I found there is some gradient shadow in the model even I use the toon shader.
I think The gradient shadow should not be appear in toon shading. Or am I setting wrong?

Below is my setting for the material:

Metallic: 0
Roughness: 0

Another issue is when the directional light enable shadow, the mesh become the following:

I think it should not happen in toon shading.

Ultimately, I just want to achieve the visual effect like this:

If I am doing something wrong, please tell me how can I get the toon shading like above (wind waker style). Thanks so much!

Steps to reproduce:
-make a meshInstance
-set the material to toon shading
-add directional light

Thank you!!

[CptPotato]

The "shadow" around the chin comes from the environment lighting. I'm not sure if there's a way to disable it with a flag.

The second shadow problem has workarounds but there's no perfect way. Using a normal offset and good bias value usually takes care of it pretty well.
Also, the screenshot you posted does not use shadows - so that would be an option, too, if you want to go for that specific look.

[nagasawamaki]

thank you. so now the problem is due to the shadow from the environment lighting?
Can the shadow also be calculated as toon shaded shadow?
Or just as you said can the shadow be disabled?

Thank you.

[nunodonato]

toon shading works well with directional lights. if you use omnilight or your sky is contributing to ambient light, you get this kind of shading. not sure if supposed to be or bug

[nagasawamaki]

if no ambient light, objects which do not receive the directional light will become black.
Then how can I achieve the same result as the screenshot I posted (like the Wind Waker)?

[nunodonato]

@nagasawamaki you can use ambient light to have some basic light in all objects, just disable(or reduce) the sky contribution in the world environment node, that's the issue

[clayjohn]

@nagasawamaki using the suggested settings were you able to get things figured out? If so, can we close this issue?

[QbieShay]

On v 3.2.stable.official this problem still appears:

[volzhs]

what @nunodonato suggested is use ambient light and disable the sky contribution.
you disabled ambient light.

[QbieShay]

@volzhs ah yes, you are correct.
I tried, but i still see soft shading on the face.

[volzhs]

what about setting Background > Energy to 0?

[QbieShay]

The sky becomes black, the model is unaffected.

[volzhs]

I guess this will help you.
https://www.youtube.com/watch?v=laastFVkTaA

or using built-in material
https://www.youtube.com/watch?v=1duRtTEc2SU

[clayjohn]

Try background energy of 1 and ambient energy of 0.

Also, this has been fixed in 4.0. You can now disable radiance and/or irradiance as you choose.

[QbieShay]

Here:

@clayjohn any chance this can be fixed for 3.2.x? I could do it with a bit of help, if that's desired.

[QbieShay]

Managed to obtain the typical banding, but it does not behave as expected. Opened a proposal with more detail here. godotengine/godot-proposals#484

[Calinou]

Closing in favor of godotengine/godot-proposals#484, as feature proposals are now tracked on the Godot proposals repository.